[GitHub] [camel] PyvesB commented on a change in pull request #6151: CAMEL-16594 Support more than one active shard in DynamoDB stream.

[GitBox <gi...@apache.org>]

PyvesB commented on a change in pull request #6151:
URL: https://github.com/apache/camel/pull/6151#discussion_r714663418



##########
File path: components/camel-aws/camel-aws2-ddb/src/main/java/org/apache/camel/component/aws2/ddbstream/Ddb2StreamConsumer.java
##########
@@ -33,14 +35,13 @@
 import software.amazon.awssdk.services.dynamodb.model.GetRecordsRequest;
 import software.amazon.awssdk.services.dynamodb.model.GetRecordsResponse;
 import software.amazon.awssdk.services.dynamodb.model.Record;
-import software.amazon.awssdk.services.dynamodb.streams.DynamoDbStreamsClient;
 
 public class Ddb2StreamConsumer extends ScheduledBatchPollingConsumer {
 
     private static final Logger LOG = LoggerFactory.getLogger(Ddb2StreamConsumer.class);
 
     private final ShardIteratorHandler shardIteratorHandler;
-    private String lastSeenSequenceNumber;
+    private final Map<String, String> lastSeenSequenceNumbers = new HashMap<>();

Review comment:
       I'd expect the number of entries to always remain quite low. The highest number of shards I've personally seen in practice is 7.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org