You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/30 06:53:59 UTC

[GitHub] [iceberg] nastra opened a new pull request, #6314: Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties

nastra opened a new pull request, #6314:
URL: https://github.com/apache/iceberg/pull/6314

   Looks like this was removed by https://github.com/apache/iceberg/pull/6045 
   /cc @szehon-ho @haizhou-zhao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] RussellSpitzer merged pull request #6314: Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties

Posted by GitBox <gi...@apache.org>.
RussellSpitzer merged PR #6314:
URL: https://github.com/apache/iceberg/pull/6314


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] gaborkaszab commented on pull request #6314: Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties

Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on PR #6314:
URL: https://github.com/apache/iceberg/pull/6314#issuecomment-1331815434

   LGTM, makes sense!
   
   I tried to create a milestone for 1.3 to include deprecating TableProperties.HMS_TABLE_OWNER so that we won't forget, but I haven't found a way to create that milestone (I guess I lack permissions). I created the issue though, to drop this field. @Fokko could you please take a look if you can create that milestone?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] gaborkaszab commented on pull request #6314: Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties

Posted by GitBox <gi...@apache.org>.
gaborkaszab commented on PR #6314:
URL: https://github.com/apache/iceberg/pull/6314#issuecomment-1331882217

   @Fokko Thanks for creating 1.3.0 milestone! However, I see you added this ticket to the milestone but this in fact is meant to be in 1.2.0 to deprecate that field, and https://github.com/apache/iceberg/issues/6316 is meant to be in 1.3.0 to drop it. I added it accordingly and removed this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] RussellSpitzer commented on pull request #6314: Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties

Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on PR #6314:
URL: https://github.com/apache/iceberg/pull/6314#issuecomment-1332377102

   Thanks @nastra for getting this! Thanks @Fokko for the review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] szehon-ho commented on pull request #6314: Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties

Posted by GitBox <gi...@apache.org>.
szehon-ho commented on PR #6314:
URL: https://github.com/apache/iceberg/pull/6314#issuecomment-1334176715

   Thanks a lot for the fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] Fokko commented on pull request #6314: Core: Re-add and deprecate HMS_TABLE_OWNER to TableProperties

Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #6314:
URL: https://github.com/apache/iceberg/pull/6314#issuecomment-1331871565

   @gaborkaszab Sure, created and added 👍🏻 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org