You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2024/10/30 11:54:25 UTC
[PR] Bring back documentation publishing to Canary builds [airflow]
potiuk opened a new pull request, #43509:
URL: https://github.com/apache/airflow/pull/43509
We are using the same approach as in
https://github.com/apache/airflow-site/pull/1055/ where we utilise /mnt directory to store checked out airflow-site.
Fixes: #41931
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2449846334
I hope I got this right this-time. It's not only the sudo, but the `df -h` had shown that we did not have this extra space and it was because ASF self-hosted runners we used to use for publishing actually did not have this extra volume mounted.
I switched back publlishing and doc building back to public runners and :crossed_fingers: it will work this time.
We will see in 2 hours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2447760677
So... Not that easy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2446849773
This seems to be even simpler than https://github.com/apache/airflow-site/pull/1055 as we only need to really use the /mnt space for the airflow-site separate checkout .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2450660665
Finally!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #43509:
URL: https://github.com/apache/airflow/pull/43509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2447221965
Spellcheck still running in 1h 30 minutes - hopefully last pass of the spellcheck now. Testing this change is a PAIN. I understand @kaxil why it was not high priority :D
BTW. Might want to optimise that one but when we have regular pushes - this will happen way less frequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2450721622
Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2450430757
🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2447758505
Failing with
```
fatal: could not create work tree dir '/mnt/airflow-site/airflow-site': Permission denied
```
😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2447231482
This is really bad thing that is happening -> downloading inventories (old) -> running spellcheck for all providers -> failing some as inventories are outdated and miss some references -> cleaning all -> running build together (failing for some cases - because local inventories were outdated) -> re-running again -> failing a bit less number of those as local inventories were rebuilt -> re-running build again for the remaining ones -> running spellcheck for all of them now with locally rebuilt inventories -> it's a bit madness :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2450276295
Almost:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2446880167
Example here: https://github.com/apache/airflow/actions/runs/11591221918/job/32271148668?pr=43503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2450833262
> Nice
Yeah... ❤️ it too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2446872396
BTW. I want to get it out "quick-ish" because it causes very long "spellcheck" checks on some PRs because first pass of spell-check does not local build, so if inventories are out-dated, it will try to spellcheck, fail, and then fall-back to rebuilding everything - and it can take more than hour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bring back documentation publishing to Canary builds [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43509:
URL: https://github.com/apache/airflow/pull/43509#issuecomment-2447764087
Right ... Sudo :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org