You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Maksim Timonin (Jira)" <ji...@apache.org> on 2025/07/01 15:51:00 UTC

[jira] [Commented] (IGNITE-23120) Improve inline index feature

    [ https://issues.apache.org/jira/browse/IGNITE-23120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987255#comment-17987255 ] 

Maksim Timonin commented on IGNITE-23120:
-----------------------------------------

Hi [~phillippko]

 

>> Then will add this check to InlineRecommender.recommend, not on tree creation

Yes, I propose to add additional check to InlineRecommender. If inlineSize > threshold then WARN. 

But you need check it, I'm not sure that the place we invoke the recommender now is in a right place for a described scenario. If you find that this is not a very good idea, then OK. Let's write somewhere else.

>> Should it be done only once, or every X (1000) invocations as with another check

I'd make it regular (every X times), to highlight importance of that.

>> There is a way to disable a warn?

Actually, I thought that there is a way to disable the recommender. But it's not. Not a problem I think.

>> How to choose reasonable percentage?)) Could we set a large limit (i.e. 20%) and leave it to users to perftest further?
 
We can set up it to 40% (~ you calculated it above), if there is no other calculations or ideas. Later we can make it more restrictive if needed.
 

 

 

 

> Improve inline index feature
> ----------------------------
>
>                 Key: IGNITE-23120
>                 URL: https://issues.apache.org/jira/browse/IGNITE-23120
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Vladimir Pligin
>            Assignee: Philipp Shergalis
>            Priority: Major
>
> Ignite allows index rows to be inlined directly into the page. However, it doesn’t guard properly against too big inline size values. Currently, it uses {{PageIO.MAX_PAYLOAD_SIZE}} as the maximum allowed value, but this value can still be too large, because it does not take the page size and encryption (which adds additional bytes to the page header) into account. This possibly leads to a bad situation when only one item can fit in one page which can lead to BTree performance degradation.
> The following is expected to be done:
>  # When inline size for an index is set, a maximum inline size should be computed:
>  ## Considering we want to have _at least_ 2 items per page, here’s how the page layout with max inline size will look like: {{PS = H + L + I + L + I + L}} . Where PS - Page Size, H - page header size, L - size of the child link, I - item size.
>  ## Using the above equation, we get the max possible item size to be equal to: {{I = (PS - H - 3L) / 2}} . However, for inline indexes, every item has an additional overhead to the actual inlined value (a.k.a payload), which depends on MVCC being present.
>  ## Taking this into account, the maximum payload size will be equal: {{P = (PS - H - 3L) / 2 - X}} , where P - Payload size, X - overhead per item.
>  ## In implementation terms, {{PS}} must be computed using the {{PageMemory#realPageSize}} which takes encryption overhead into account,{{{}H{}}} is equal to {{{}BPlusIo#ITEMS_OFF{}}}, {{L}} is 8 bytes and {{X}} depends on the actual {{AbstractH2ExtrasInnerIO}} implementation and varies between 8 and 28 bytes.
>  # If the configured inline size exceeds the computed maximum size or {{PageIO.MAX_PAYLOAD_SIZE}} then an exception must be thrown with a message that notifies the user of the incorrect inline size value. Note that this should only happen for _new_ indexes, if a nodes is started on top of an existing PDS, no exceptions should be thrown and a warning should be printed instead, to preserve backwards compatibility.
>  # Fix the “Indexed columns of a row cannot be fully inlined into index” warning to recommend at most the maximum allowed inline size.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)