[GitHub] [arrow] vibhatha commented on a diff in pull request #13490: ARROW-16910: [C++] Add Equals method for FileFragment

[GitBox <gi...@apache.org>]

vibhatha commented on code in PR #13490:
URL: https://github.com/apache/arrow/pull/13490#discussion_r912067303


##########
cpp/src/arrow/dataset/test_util.h:
##########
@@ -555,6 +555,21 @@ class FileFormatFixtureMixin : public ::testing::Test {
     ASSERT_OK_AND_ASSIGN(predicate, predicate.Bind(*full_schema));
     ASSERT_FINISHES_OK_AND_EQ(util::nullopt, fragment->CountRows(predicate, options));
   }
+  void TestFragmentEquals() {
+    auto options = std::make_shared<ScanOptions>();
+    auto test_schema = schema({field("f64", float64())});
+    auto reader = this->GetRecordBatchReader(test_schema);
+    auto other_reader = this->GetRecordBatchReader(test_schema);
+    auto source = this->GetFileSource(reader.get());
+    auto other_source = this->GetFileSource(other_reader.get());
+
+    auto fragment = this->MakeFragment(*source);
+    auto other = this->MakeFragment(*other_source);
+
+    EXPECT_EQ(fragment->Equals(*other), false);
+    // TODO: Extend the test cases for Fragment
+    // when ARROW-16855 is merged.

Review Comment:
   Yes. I need to mention this in other PR as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org