You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by ChinmaySKulkarni <gi...@git.apache.org> on 2018/04/12 07:34:46 UTC
[GitHub] phoenix pull request #297: PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS...
GitHub user ChinmaySKulkarni opened a pull request:
https://github.com/apache/phoenix/pull/297
PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS and VERSIONS should be property driven
Adds configurable properties for KEEP_DELETED_CELLS and VERSIONS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-4575
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #297
----
commit f501bfacde19282cb2084b3afefc52c51b6951cb
Author: Chinmay Kulkarni <ch...@...>
Date: 2018-04-12T07:29:50Z
PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS and VERSIONS should be property driven
Adds configurable properties for KEEP_DELETED_CELLS and VERSIONS.
----
---
[GitHub] phoenix pull request #297: PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS...
Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni closed the pull request at:
https://github.com/apache/phoenix/pull/297
---
[GitHub] phoenix issue #297: PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS and VE...
Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni commented on the issue:
https://github.com/apache/phoenix/pull/297
@JamesRTaylor rebased. @ankitsinghal phoenix build seems to be failing after commit 70c9c6bb2d2073bb40640a0a794032b166c4b63b for PHOENIX-4496. Please take a look.
---
[GitHub] phoenix issue #297: PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS and VE...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/297
+1. Thanks for taking this to the finish line, @ChinmaySKulkarni. Is this on top of your patch for PHOENIX-4579? What order should I commit them?
---
[GitHub] phoenix issue #297: PHOENIX-4575: Phoenix metadata KEEP_DELETED_CELLS and VE...
Posted by ChinmaySKulkarni <gi...@git.apache.org>.
Github user ChinmaySKulkarni commented on the issue:
https://github.com/apache/phoenix/pull/297
@JamesRTaylor please review. Thanks @mujtabachohan for your initial patches.
- Added nit changes as suggested by James on JIRA
- Rebased with master
- @ankitsinghal please check that this does not break anything related to your recent contributions corresponding to Query Log [PHOENIX-2715](https://issues.apache.org/jira/browse/PHOENIX-2715).
Changes are made to SYSLOG ddl statement. "KEEP_DELETED_CELLS" is by default false now (before the default value was true).
- Ran all UTs in the that are part of PHOENIX-2715 and ran UTs that are relevant to sys table creation and upgrade -> All passed.
---