You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/19 16:41:02 UTC
[GitHub] [spark] yangwwei commented on a change in pull request #34319: [SPARK-37049] executorIdleTimeout is not working for pending pods on K8s
yangwwei commented on a change in pull request #34319:
URL: https://github.com/apache/spark/pull/34319#discussion_r732055721
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##########
@@ -456,11 +456,11 @@ class ExecutorPodsAllocator(
private def isExecutorIdleTimedOut(state: ExecutorPodState, currentTime: Long): Boolean = {
try {
- val startTime = Instant.parse(state.pod.getStatus.getStartTime).toEpochMilli()
+ val startTime = Instant.parse(state.pod.getMetadata.getCreationTimestamp).toEpochMilli()
currentTime - startTime > executorIdleTimeout
} catch {
- case _: Exception =>
- logDebug(s"Cannot get startTime of pod ${state.pod}")
+ case e: Exception =>
+ logError(s"Cannot get the createTime of the pod $state.pod", e)
Review comment:
Updated, also updated the PR description
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##########
@@ -456,11 +456,11 @@ class ExecutorPodsAllocator(
private def isExecutorIdleTimedOut(state: ExecutorPodState, currentTime: Long): Boolean = {
try {
- val startTime = Instant.parse(state.pod.getStatus.getStartTime).toEpochMilli()
+ val startTime = Instant.parse(state.pod.getMetadata.getCreationTimestamp).toEpochMilli()
currentTime - startTime > executorIdleTimeout
} catch {
- case _: Exception =>
- logDebug(s"Cannot get startTime of pod ${state.pod}")
+ case e: Exception =>
+ logError(s"Cannot get the createTime of the pod $state.pod", e)
Review comment:
Updated, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org