You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/11/21 17:21:29 UTC

Review Request 63989: Added the OFFER_OPERATION_DROPPED state.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63989/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.


Bugs: MESOS-8190
    https://issues.apache.org/jira/browse/MESOS-8190


Repository: mesos


Description
-------

This patch adds a new state for offer operations,
OFFER_OPERATION_DROPPED, which is meant to be analogous
to the TASK_DROPPED task state. The master and agent will
send this state in offer operation updates when an
operation is dropped due to a transient error.


Diffs
-----

  include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
  include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
  src/common/protobuf_utils.cpp 34054846f93f19ba550afe58e2a899d111ad38dc 
  src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 
  src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080 


Diff: https://reviews.apache.org/r/63989/diff/1/


Testing
-------

make check


Thanks,

Greg Mann


Re: Review Request 63989: Added the OFFER_OPERATION_DROPPED state.

Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63989/#review191758
-----------------------------------------------------------


Ship it!




Ship It!

- Gaston Kleiman


On Nov. 21, 2017, 9:21 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63989/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 9:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8190
>     https://issues.apache.org/jira/browse/MESOS-8190
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new state for offer operations,
> OFFER_OPERATION_DROPPED, which is meant to be analogous
> to the TASK_DROPPED task state. The master and agent will
> send this state in offer operation updates when an
> operation is dropped due to a transient error.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e194093e490741acc552fd3ad328fd710b4b4435 
>   include/mesos/v1/mesos.proto 6fb1139683952877667abbcf8bf84b5b31bcd29e 
>   src/common/protobuf_utils.cpp 34054846f93f19ba550afe58e2a899d111ad38dc 
>   src/master/master.cpp 7417b5d641fd4bb6d91cb0e6456c60201bbc8206 
>   src/slave/slave.cpp 6e9adc60f593faf1b0e56caeea04882f67af7080 
> 
> 
> Diff: https://reviews.apache.org/r/63989/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Greg Mann
> 
>