You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/03 02:22:57 UTC
[GitHub] [flink] zjuwangg commented on a change in pull request #10296:
[FLINK-14691][table]Add use/create/drop/alter database operation and
support it in flink/blink planner
zjuwangg commented on a change in pull request #10296: [FLINK-14691][table]Add use/create/drop/alter database operation and support it in flink/blink planner
URL: https://github.com/apache/flink/pull/10296#discussion_r352956870
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -301,10 +301,10 @@ public boolean databaseExists(String databaseName) throws CatalogException {
}
@Override
- public void dropDatabase(String name, boolean ignoreIfNotExists) throws DatabaseNotExistException,
- DatabaseNotEmptyException, CatalogException {
+ public void dropDatabase(String name, boolean ignoreIfNotExists, boolean restrict)
Review comment:
But if so, we must call `client.dropDatabse(name, true, ignoreifNotExists, !cascade)`.
The `!cascade` is not consistent with the original method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services