You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by ManoharVanam <gi...@git.apache.org> on 2016/09/23 07:00:41 UTC

[GitHub] incubator-carbondata pull request #192: [CARBONDATA-269]change delete segmen...

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/192#discussion_r80060992
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -1181,23 +1182,21 @@ class CarbonSqlParser()
             p.getClass.getSimpleName.equals("DecimalLit") } ) ^^ (_.chars)
     
       protected lazy val deleteLoadsByID: Parser[LogicalPlan] =
    -    DELETE ~> SEGMENT ~> repsep(segmentId, ",") ~ (FROM ~> TABLE ~>
    -      (ident <~ ".").? ~ ident) <~
    +    DELETE ~> FROM ~ TABLE ~> (ident <~ ".").? ~ ident ~
    +      (WHERE ~> SEGMENT ~> EQUAL ~> repsep(segmentId, ",")) <~
    --- End diff --
    
    I think its better to use segments in both places deleteLoadsByID , deleteLoadsByLoadDate to avoid confusion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---