You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "TestBoost (via GitHub)" <gi...@apache.org> on 2023/12/12 05:17:52 UTC
[PR] only close the cluster once to make the tests faster [flink]
TestBoost opened a new pull request, #23910:
URL: https://github.com/apache/flink/pull/23910
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This change is to make `miniCluster.close()` run only once after all tests finish and make the tests in test class `ClientHeartbeatTest` run faster. There are three tests in this test class. They are trying to submit different jobs through the cluster and assert the running status of `miniCluster` or the job status of submitted job. These tests are submitting jobs that are not related to each other. We also try to run these tests in different orders and they always pass.
Besides, test class `ClientHeartbeatTest` is similar to the test class `org.apache.flink.runtime.leaderelection.LeaderChangeClusterComponentsTest`. However, test class
`LeaderChangeClusterComponentsTest` only close the `miniCluster` after all tests finish. It is a good choice to apply similar approach to the test class `ClientHeartbeatTest`.
The test runtime can change from `9.9113 s` to `8.9771 s` after applying this change.
## Brief change log
- This pull request changes the code such that `miniCluster.close()` run once after all tests finish rather than run after every test.
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
This pull request is just modifying tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-Clients] [Test] only close the cluster once to make the test `ClientHeartbeatTest` faster [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #23910:
URL: https://github.com/apache/flink/pull/23910#issuecomment-1851491496
> Yes, right now the test cluster is started before every test method.
Then we should change the code to not start cluster per-test at the same time.
To be honest, I'm not prefer this change. This `ClientHeartbeatTest` is a bit unstable already, I'm worried this will make it more vulnerable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23910:
URL: https://github.com/apache/flink/pull/23910#issuecomment-2850024834
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33776] [Test] only close the cluster once to make the test `ClientHeartbeatTest` faster [flink]
Posted by "TestBoost (via GitHub)" <gi...@apache.org>.
TestBoost commented on PR #23910:
URL: https://github.com/apache/flink/pull/23910#issuecomment-1851472434
Hi reswqa,
Thank you so much for your reply! I just changed the title but I don't know if it's suitable.
Yes, right now the test cluster is started before every test method. However, there is no need to start per-test because these tests are not affecting each other and we can test it just on the same cluster.
Thanks,
TestBoost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23910:
URL: https://github.com/apache/flink/pull/23910#issuecomment-2777668722
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]
Posted by "TestBoost (via GitHub)" <gi...@apache.org>.
TestBoost commented on PR #23910:
URL: https://github.com/apache/flink/pull/23910#issuecomment-1856543512
Hi,
So to clarify, would the preferred change be to start a cluster per-test-class and to share between test methods? Looking at the test class, perhaps this could be accomplished by sharing the `JobClient` object that each test method creates (though perhaps `testJobRunningIfDisableClientHeartbeat` cannot easily share due to a difference in configuration)? Or perhaps do you have another kind of change in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #23910: [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`.
URL: https://github.com/apache/flink/pull/23910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] only close the cluster once to make the tests faster [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23910:
URL: https://github.com/apache/flink/pull/23910#issuecomment-1851322851
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b0fd64a2a24dc1cd50ea2fb5ae4f3d4036e2b85a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b0fd64a2a24dc1cd50ea2fb5ae4f3d4036e2b85a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0fd64a2a24dc1cd50ea2fb5ae4f3d4036e2b85a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] [tests] Per-class the lifecycle of mini-cluster in `ClientHeartbeatTest`. [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #23910:
URL: https://github.com/apache/flink/pull/23910#issuecomment-1857249121
To be honest, I prefer to leave it as it is. Since I don't see much benefit, this `1s` speed up doesn't necessarily show up in the CI environment, but it does increase the instability of the test class (especially this class shows the characteristics of flaky test to some extent 😞).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org