You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/30 23:32:57 UTC
[GitHub] [incubator-druid] jihoonson commented on a change in pull request
#7531: Data loader (sampler component)
jihoonson commented on a change in pull request #7531: Data loader (sampler component)
URL: https://github.com/apache/incubator-druid/pull/7531#discussion_r279938345
##########
File path: .gitignore
##########
@@ -13,5 +13,7 @@ target
*.log
*.DS_Store
_site
+indexing-service/foo/*
+indexing-service/testDataSource/*
Review comment:
Hmm it looks that these directories are used in some tests, but I think any test directory should be under `$PACKAGE_ROOT/target/`. How about fixing those tests rather than adding these directories to `.gitignore`? I would like to not add them because they would remind me this issue whenever I see them. I don't think finding and fixing tests don't have to be done in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org