You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/25 11:00:29 UTC
[GitHub] [incubator-nuttx] eenurkka opened a new pull request #5840: Rpmsg warnings
eenurkka opened a new pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840
## Summary
Fix a few warnings related to RPMSG.
## Impact
No functional changes
## Testing
Compile-time only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #5840: Rpmsg warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] eenurkka commented on a change in pull request #5840: Rpmsg warnings
Posted by GitBox <gi...@apache.org>.
eenurkka commented on a change in pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840#discussion_r835194764
##########
File path: drivers/rptun/rptun.c
##########
@@ -953,7 +953,7 @@ int rptun_initialize(FAR struct rptun_dev_s *dev)
goto err_driver;
}
- snprintf(arg1, 16, "0x%" PRIxPTR, (uintptr_t)priv);
+ snprintf(arg1, 19, "0x%" PRIxPTR, (uintptr_t)priv);
Review comment:
Right, will re-post
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5840: Rpmsg warnings
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5840:
URL: https://github.com/apache/incubator-nuttx/pull/5840#discussion_r835193465
##########
File path: drivers/rptun/rptun.c
##########
@@ -953,7 +953,7 @@ int rptun_initialize(FAR struct rptun_dev_s *dev)
goto err_driver;
}
- snprintf(arg1, 16, "0x%" PRIxPTR, (uintptr_t)priv);
+ snprintf(arg1, 19, "0x%" PRIxPTR, (uintptr_t)priv);
Review comment:
```suggestion
snprintf(arg1, sizeof(arg1), "0x%" PRIxPTR, (uintptr_t)priv);
```
and same for `name` above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org