You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "rgolangh (via GitHub)" <gi...@apache.org> on 2024/08/15 14:52:10 UTC
[PR] Add missing instruction on adding the CA configmap [incubator-kie-kogito-docs]
rgolangh opened a new pull request, #669:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/669
Signed-off-by: Roy Golan <rg...@redhat.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Add missing instruction on adding the CA configmap [incubator-kie-kogito-docs]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #669:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/669#discussion_r1723256286
##########
serverlessworkflow/modules/ROOT/pages/cloud/operator/add-custom-ca-to-a-workflow-pod.adoc:
##########
@@ -136,6 +136,17 @@ spec:
Similar to a deployment spec, a serverless workflow has a spec.podTemplate, with minor differences, but the change is almost identical.
In this case, we are mounting some ingress ca-bundle because we want our workflow to reach the `.apps.my-cluster-name.my-cluster-domain` SSL endpoint.
+
+In this example we pull the ingress CA of OpenShift's ingress deployment because this
+is the CA that is used to sign certificates for routes. It can be any CA that is signing the target service certificate.
+Here's how to copy the ingress ca cert to the desired namespace:
Review Comment:
```suggestion
In this example, we pull the ingress CA of OpenShift's ingress deployment because this is the CA that signs the target routes' certificates. It can be any CA that is signing the target service certificate.
Here's how to copy the ingress ca cert to the desired namespace:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Add missing instruction on adding the CA configmap [incubator-kie-kogito-docs]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #669:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/669#issuecomment-2330188178
@domhanak @wmedvede can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Add missing instruction on adding the CA configmap [incubator-kie-kogito-docs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #669:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/669#issuecomment-2291447285
🎊 PR Preview 9517469c21b503d377f9238cb92af5f631e79205 has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-669.surge.sh
<!-- Sticky Pull Request Comment -->
<!-- Sticky Pull Request Comment -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Add missing instruction on adding the CA configmap [incubator-kie-kogito-docs]
Posted by "domhanak (via GitHub)" <gi...@apache.org>.
domhanak merged PR #669:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Add missing instruction on adding the CA configmap [incubator-kie-kogito-docs]
Posted by "rgolangh (via GitHub)" <gi...@apache.org>.
rgolangh commented on PR #669:
URL: https://github.com/apache/incubator-kie-kogito-docs/pull/669#issuecomment-2329669290
Can this be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org