You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org> on 2018/08/16 23:49:46 UTC
Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/
-----------------------------------------------------------
Review request for hive, Alexander Kolbasov and Peter Vary.
Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306
Repository: hive-git
Description
-------
HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
Diffs
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AbortTxnsRequest.java 7dcfc170cc86f237398aad1536c3fbd79561d5a9
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddCheckConstraintRequest.java 8ece410555619626797770206e7d959cd6c31e6f
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDefaultConstraintRequest.java 8a125d854edea766610eca8fe7a8a8f1ed3f5594
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDynamicPartitions.java 45618e781cea1a8090a75dfadb56262041e3a0cd
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddForeignKeyRequest.java 0f443d4f60ae6b2f55ea5d1902708d005b53cac0
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddNotNullConstraintRequest.java 0266bba2b0b9c347bc555ee7b40b4c2794e3ad41
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java 469a9a804171321e55ace6764c2cf3355f0778a9
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java a00af609d45e3f4eb055e3664a376510aec926ae
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPrimaryKeyRequest.java 9069a419ec6f6d0fba3428e556f9cd815aa714cb
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddUniqueConstraintRequest.java c47db4a91082df50169388b3d58c067069b790b4
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggrStats.java 67d9b1061477e85cc71a10c4b5cc1559ac4ee1dc
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AllocateTableWriteIdsRequest.java 5fcb98fb1b48bbff79515a984724040c5e22e602
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AllocateTableWriteIdsResponse.java 2a13eba708f177b26bbbd7455ce71101a33ea0b5
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlterPartitionsRequest.java 4d4595a429b8437e187c05cd52795f9e4885f6c4
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CheckConstraintsResponse.java 68582058ab159126dab71e68a665a81ba9781231
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClearFileMetadataRequest.java 3fdd295fb12240d7a94315a97419cc9a570c1536
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClientCapabilities.java f5c9582fa908e2d428cb897e7cc1cdd31bf45286
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatistics.java fd4619f0e5a9078e6e527e8f452a4d4e5da6a0b7
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CommitTxnRequest.java db47f9db8b094a8f34e27241e8ce33943ac90617
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CompactionRequest.java dd6df744cb60f35cff5cb58e7679e4a2b8d19ffc
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CreationMetadata.java d631e21cec66d519e376625e6c3f41d071716834
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DefaultConstraintsResponse.java e29932c5abe88217414c31c81d431dfc519e2969
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java 0a7d3b5bca893f7c673bc60fd16b655f362a33e2
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java a128dacd898ea548b535373ffdd87d8b5398056c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FindSchemasByColsResp.java 8f5b4e5bb490310a7e23e718ae8984a64f26087e
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventRequest.java dc2627a1fbdf9c8b5a03055fb071280f8aa2f5f9
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysResponse.java 8fae31cba03951f423c4a5a1d59cb2ae2f0a3b2c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java ce0feb929d705bef7bcc50f02d7e9910df9708a5
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetAllFunctionsResponse.java 13fe5fa6d5295158287dbd1c472f7b9881fd65c5
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprRequest.java 976bf001a0428e5b04da9d1ea6294344a1499c69
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprResult.java 16a0113ac00c5bbd908cd83379fe63a88f0e1f62
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataRequest.java 9e3ed8b28220f5729735aab8a4be86851210c49e
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataResult.java bc73f1ec272ddf3c0dd2d56a3f342b79a0c24644
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java 93ca30315749eab599871b8303d6b022cdf91d98
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java c152a0aab70ec496d3e84d7ac9d37f211f97e873
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetTablesRequest.java f241b5aa79e827811ac5b7297d1da1bc5978ae09
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetTablesResult.java b351c40f97c452f780f045bc71823096c172421b
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetValidWriteIdsRequest.java a5bbb86af1f05c0181debdaec4787c192f31157f
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetValidWriteIdsResponse.java 96a6a00572de5079d3d0687b00d3c8229018cedf
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java a6535aa8fc07e188ad53ff8bf6ef8d20ff5caa21
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java 70690a4e0a711e24728fff7ffc63c6019bda6938
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java cabed5af7247e559a76456745da6c94d2fad67ba
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotNullConstraintsResponse.java 54070adee31f76f741324317220893d05c9f3f0e
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventResponse.java e86c9f66080c6f97b93f939192a1a3ceb4c60967
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnRequest.java 19b2c01b3a7cd03ee336914e493987e2c376e962
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java 71a2c4fd8064d3ea55f3df68006464eda27446a3
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java e1f4021f017b7790d1a8521fd0d70838a2dfacf6
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java c3fa2a2399e5bc3e42845d8f949e0ce05f13e14c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesRequest.java 8309769eee0da93f8427b7fc6e02a96ae3787611
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesResponse.java 7bf1c61a425750aff7c4f16b013e0ef3aed1e658
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesRow.java 4c384f6408e9f1cac8dd47c2d23deab840470969
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java d43be205b21563c7cfa87bb0057aff2cd785adb0
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 27cdac609ad975f5f07bdac9e0b262d6e4142bb0
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 7e0842072f54441bdcfd7127bd1b989b5c285cd0
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java becfcc904dc0cadb81b7a93b613d074e50c3d67e
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysResponse.java db265ea4f426ff56b78f9f0081675d1115de3839
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java e19034c630d692613007d052b9134c012925064e
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RenamePartitionRequest.java 3540e993361b83d7ae299012aa73b82561339753
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ReplTblWriteIdStateRequest.java f637d519f44500cab25d071416c272a1cf5c4f6a
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java 19de923dcb62594f1154b561c26a310f49688eef
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java b4cd16f8cf08f587f7890c48aea2a52077fdc610
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SchemaVersion.java 88d7e3fedf59e6204ab133ce3d67828aa9688a94
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java 6f9053d8ab0e82ef78ebb3a646a72d10fa7d222b
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java c58885f22a7bbfb9e75f650120b850883e888e4e
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java 4bbc8e7766922455bd4ad960c49599146a2e84c6
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java ae3a6e24831ac2e37592472d383ddbe9658702fc
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java b57f4bf6b2cea166e8b462ab06e4bd564b425ad4
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableValidWriteIds.java 9c6ee51b26d62a06dcac63547a51106fbe4da760
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 7ab64eadac7948a7f5077260694926cc5b6e4e4b
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UniqueConstraintsResponse.java 1acf6f4b4ed9d4e6bce4010b534dccb52ecd6f3b
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java 44674798f718ac121c6f523d28173ff892e1d874
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java c6cb845585363d15cd50a541a72548f0745ea80a
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java 9eed335cda8561938ba68fbb8e9453c584735434
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java ee9251c86660b7f731ab7e20643dd6db7e351e3f
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WriteNotificationLogRequest.java c7ef726f5481b37561f8144b796fdadfb4254452
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php cc19f2389e7b595722dcc1f3296877a02b20e0a4
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py d098dba100bdfe56aa6ecafb31880098a2d7c6cb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 92424a43feefc8c0db7c91302045437f3afbf274
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 8a4bdd8ed827572f5fd9d291c5454630d84284bd
standalone-metastore/metastore-common/src/test/resources/metastore-site.xml PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 324035a8096a001d3fb170b8640805258d5e2cdd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 5ae00af564b05ec2720a03072f94c8f8579378a7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 91405b9a334a4b031a5dc7f4a1757a3895bfb386
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 35abd006d41f0eca354123fcfe6f590867f80cac
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 60beab6350d1f4d86bdcf79f5119172117c5ca2e
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/68395/diff/1/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
> On Aug. 27, 2018, 4:42 p.m., Aihua Xu wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java
> > Line 200 (original), 200 (patched)
> > <https://reviews.apache.org/r/68395/diff/7-8/?file=2077219#file2077219line200>
> >
> > Seems it can be static since it doesn't refer to any variables outside. Maybe I miss anything?
changed this method to static as suggested
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207981
-----------------------------------------------------------
On Aug. 25, 2018, 12:23 a.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2018, 12:23 a.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6b660f55aca5b99517447f164339ed92261c9370
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java faf6810420ccf6088a3398711c0c216af722f062
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 506d9ab5590a245049f3c4e71324823465a91586
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 6e0d9c1848cdeffc226ff6c55fd49898786c0f4c
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Aihua Xu via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207981
-----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java
Line 200 (original), 200 (patched)
<https://reviews.apache.org/r/68395/#comment291704>
Seems it can be static since it doesn't refer to any variables outside. Maybe I miss anything?
- Aihua Xu
On Aug. 25, 2018, 12:23 a.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2018, 12:23 a.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6b660f55aca5b99517447f164339ed92261c9370
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java faf6810420ccf6088a3398711c0c216af722f062
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 506d9ab5590a245049f3c4e71324823465a91586
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 6e0d9c1848cdeffc226ff6c55fd49898786c0f4c
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review208006
-----------------------------------------------------------
Very useful feature, thanks for doing this! A bunch of nits below.
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1645 (patched)
<https://reviews.apache.org/r/68395/#comment291721>
Can you put top-level comment for this struct explaining that this is an API to control both partition filtering and partition content.
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1647 (patched)
<https://reviews.apache.org/r/68395/#comment291722>
I think it is better to specify that API guarantees that it will include fields in the list although it may set some other fields as well - the contract is that *these fields* must be set.
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1654 (patched)
<https://reviews.apache.org/r/68395/#comment291723>
s/complaint/compliant/
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1656 (patched)
<https://reviews.apache.org/r/68395/#comment291725>
Can you add some statement at the top telling that the API allows for param filtering as well.
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1659 (patched)
<https://reviews.apache.org/r/68395/#comment291724>
Can you specify what happens if some match is both included and excluded?
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1668 (patched)
<https://reviews.apache.org/r/68395/#comment291727>
Do fields 1-6 belong here or in GetPartitionRequest? Essentially - are these part of the filter spec or part of the request asking for partitions?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 2612 (patched)
<https://reviews.apache.org/r/68395/#comment291740>
This wouldn't be a very useful MPart - will something set correct dbname, etc later?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 3358 (patched)
<https://reviews.apache.org/r/68395/#comment291738>
It would be good to add a comment that this is JDO-only code.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 3406 (patched)
<https://reviews.apache.org/r/68395/#comment291736>
mparts can be a huge list of objects, so printing this in debug log may be too much - may be just log number of objects?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 4035 (patched)
<https://reviews.apache.org/r/68395/#comment291734>
What about filtering params? Does it still apply?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 4051 (patched)
<https://reviews.apache.org/r/68395/#comment291739>
Nit: comments have spce after //
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 4052 (patched)
<https://reviews.apache.org/r/68395/#comment291737>
in setRange() or setResults()?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Line 4393 (original), 4508 (patched)
<https://reviews.apache.org/r/68395/#comment291741>
Is this legit change?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
Line 547 (original), 553 (patched)
<https://reviews.apache.org/r/68395/#comment291733>
Please document this API.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
Lines 554 (patched)
<https://reviews.apache.org/r/68395/#comment291730>
I don't think that `allowJDO` and `allowSql` belong here - this is an API for the raw store and jdo is an implementation detail of specific RawStore. So this should be an implementation that deals with it (probaby based on config or hardcore values) but we shouldn't be exposing this in the interface.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
Lines 555 (patched)
<https://reviews.apache.org/r/68395/#comment291731>
What if we later extern projectionSpec or filters to include more things? Would we need to add new methods here? Can we just pass either original Thrift request structs or some some representation of these so that we can extend things later without introducing new API methods?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
Lines 556 (patched)
<https://reviews.apache.org/r/68395/#comment291732>
When would it return `NoSuchObjectException`?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 991 (patched)
<https://reviews.apache.org/r/68395/#comment291742>
This is a public method, so it would benefit from documentation
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 1179 (patched)
<https://reviews.apache.org/r/68395/#comment291743>
Neat, didn't know about Objects.hash
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java
Lines 1209 (patched)
<https://reviews.apache.org/r/68395/#comment291744>
Hmm, this looks suspicious. Objects can have the same hash code and be non-equal - shouldn't you compare values? Looks like you can use `Objects.equals` for this purpose.
- Alexander Kolbasov
On Aug. 27, 2018, 10:33 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2018, 10:33 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 33b22a9fc3e60cb6e11bec63d397f1fa712a41db
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java a0ff79cc5ca39f8af8bac672393e82d365c9fd4a
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MStorageDescriptor.java 4c6ce008f89469353bfee3175168a518534a42b1
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 10ff9dfbb6d8f61fa75f731f4cd0f006c98e0067
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java c681a87a1c6b10a4f9494e49a42282cf90027ad7
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 4093aa7a18e52e1edbad2a872efe4d9b7cfe5b21
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/
-----------------------------------------------------------
(Updated Aug. 27, 2018, 10:33 p.m.)
Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
Changes
-------
Added support for JDO result for projected fields.
Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306
Repository: hive-git
Description
-------
HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 33b22a9fc3e60cb6e11bec63d397f1fa712a41db
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java a0ff79cc5ca39f8af8bac672393e82d365c9fd4a
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MStorageDescriptor.java 4c6ce008f89469353bfee3175168a518534a42b1
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 10ff9dfbb6d8f61fa75f731f4cd0f006c98e0067
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java c681a87a1c6b10a4f9494e49a42282cf90027ad7
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 4093aa7a18e52e1edbad2a872efe4d9b7cfe5b21
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/68395/diff/9/
Changes: https://reviews.apache.org/r/68395/diff/8-9/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Aihua Xu via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207983
-----------------------------------------------------------
Ship it!
Ship It!
- Aihua Xu
On Aug. 25, 2018, 12:23 a.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2018, 12:23 a.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6b660f55aca5b99517447f164339ed92261c9370
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java faf6810420ccf6088a3398711c0c216af722f062
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 506d9ab5590a245049f3c4e71324823465a91586
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 6e0d9c1848cdeffc226ff6c55fd49898786c0f4c
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/
-----------------------------------------------------------
(Updated Aug. 25, 2018, 12:23 a.m.)
Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
Changes
-------
Made changes suggested by Aihua
Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306
Repository: hive-git
Description
-------
HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6b660f55aca5b99517447f164339ed92261c9370
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java faf6810420ccf6088a3398711c0c216af722f062
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 506d9ab5590a245049f3c4e71324823465a91586
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 6e0d9c1848cdeffc226ff6c55fd49898786c0f4c
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/68395/diff/8/
Changes: https://reviews.apache.org/r/68395/diff/7-8/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
> On Aug. 24, 2018, 11:19 p.m., Aihua Xu wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
> > Line 376 (original), 416 (patched)
> > <https://reviews.apache.org/r/68395/diff/7/?file=2077216#file2077216line417>
> >
> > Why some functions like extractSqlString() not moving into MetastoreDirectSqlUtils class, but extractSqlLong() gets moved? Can we make it consistent?
I moved only the functions which were needed in PartitionProjectionEvaluator class. Makes sense to move these as well to keep it consistent.
> On Aug. 24, 2018, 11:19 p.m., Aihua Xu wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
> > Lines 547 (patched)
> > <https://reviews.apache.org/r/68395/diff/7/?file=2077216#file2077216line548>
> >
> > Better add comments for this public function.
Added a javadoc
> On Aug. 24, 2018, 11:19 p.m., Aihua Xu wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
> > Lines 886 (patched)
> > <https://reviews.apache.org/r/68395/diff/7/?file=2077216#file2077216line1040>
> >
> > This function is a little confusing actually. Since we are not used anywhere else, probably we don't need to create such function seperately.
this was a left over from some of my code changes while development. Reverted this part.
> On Aug. 24, 2018, 11:19 p.m., Aihua Xu wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java
> > Lines 200 (patched)
> > <https://reviews.apache.org/r/68395/diff/7/?file=2077219#file2077219line200>
> >
> > This function can be static and probably gives the name find() as well? findUtil is a little confusing to me.
This method cannot be changed to static since it operates on the roots field which is non-static. renamed the findUtil to find as suggested.
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207920
-----------------------------------------------------------
On Aug. 25, 2018, 12:23 a.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2018, 12:23 a.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6b660f55aca5b99517447f164339ed92261c9370
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java faf6810420ccf6088a3398711c0c216af722f062
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 506d9ab5590a245049f3c4e71324823465a91586
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 6e0d9c1848cdeffc226ff6c55fd49898786c0f4c
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Aihua Xu via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207920
-----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Line 376 (original), 416 (patched)
<https://reviews.apache.org/r/68395/#comment291563>
Why some functions like extractSqlString() not moving into MetastoreDirectSqlUtils class, but extractSqlLong() gets moved? Can we make it consistent?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Lines 547 (patched)
<https://reviews.apache.org/r/68395/#comment291564>
Better add comments for this public function.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Lines 886 (patched)
<https://reviews.apache.org/r/68395/#comment291561>
This function is a little confusing actually. Since we are not used anywhere else, probably we don't need to create such function seperately.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java
Lines 200 (patched)
<https://reviews.apache.org/r/68395/#comment291568>
This function can be static and probably gives the name find() as well? findUtil is a little confusing to me.
- Aihua Xu
On Aug. 24, 2018, 6:15 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 6:15 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6b660f55aca5b99517447f164339ed92261c9370
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java faf6810420ccf6088a3398711c0c216af722f062
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 506d9ab5590a245049f3c4e71324823465a91586
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 6e0d9c1848cdeffc226ff6c55fd49898786c0f4c
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/
-----------------------------------------------------------
(Updated Aug. 24, 2018, 6:15 p.m.)
Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
Changes
-------
Added some of the suggested changes by Alexander
Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306
Repository: hive-git
Description
-------
HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 7ab64eadac7948a7f5077260694926cc5b6e4e4b
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php cc19f2389e7b595722dcc1f3296877a02b20e0a4
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py d098dba100bdfe56aa6ecafb31880098a2d7c6cb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 92424a43feefc8c0db7c91302045437f3afbf274
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 8a4bdd8ed827572f5fd9d291c5454630d84284bd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 324035a8096a001d3fb170b8640805258d5e2cdd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 5ae00af564b05ec2720a03072f94c8f8579378a7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 91405b9a334a4b031a5dc7f4a1757a3895bfb386
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 35abd006d41f0eca354123fcfe6f590867f80cac
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 60beab6350d1f4d86bdcf79f5119172117c5ca2e
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/68395/diff/6/
Changes: https://reviews.apache.org/r/68395/diff/5-6/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 8:06 p.m.)
Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
Changes
-------
added catName in the thrift definition for filterspec as suggested.
Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306
Repository: hive-git
Description
-------
HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 7ab64eadac7948a7f5077260694926cc5b6e4e4b
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php cc19f2389e7b595722dcc1f3296877a02b20e0a4
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py d098dba100bdfe56aa6ecafb31880098a2d7c6cb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 92424a43feefc8c0db7c91302045437f3afbf274
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 8a4bdd8ed827572f5fd9d291c5454630d84284bd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 324035a8096a001d3fb170b8640805258d5e2cdd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 5ae00af564b05ec2720a03072f94c8f8579378a7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 91405b9a334a4b031a5dc7f4a1757a3895bfb386
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 35abd006d41f0eca354123fcfe6f590867f80cac
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 60beab6350d1f4d86bdcf79f5119172117c5ca2e
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/68395/diff/5/
Changes: https://reviews.apache.org/r/68395/diff/4-5/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 6:44 p.m.)
Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
Changes
-------
Addressed some of the review comments. More to come.
Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306
Repository: hive-git
Description
-------
HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 7ab64eadac7948a7f5077260694926cc5b6e4e4b
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php cc19f2389e7b595722dcc1f3296877a02b20e0a4
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py d098dba100bdfe56aa6ecafb31880098a2d7c6cb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 92424a43feefc8c0db7c91302045437f3afbf274
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 8a4bdd8ed827572f5fd9d291c5454630d84284bd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 324035a8096a001d3fb170b8640805258d5e2cdd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 5ae00af564b05ec2720a03072f94c8f8579378a7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 91405b9a334a4b031a5dc7f4a1757a3895bfb386
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 35abd006d41f0eca354123fcfe6f590867f80cac
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 60beab6350d1f4d86bdcf79f5119172117c5ca2e
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/68395/diff/4/
Changes: https://reviews.apache.org/r/68395/diff/3-4/
Testing
-------
Thanks,
Vihang Karajgaonkar
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Lines 1646 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075732#file2075732line1646>
> >
> > does this allow for x.y.z?
> > Does this work for sd columns and other list fields?
yes, this works for multi-valued fields, so something like sd.cols.name will work. Only name will be set for all the sd.cols for each partition. I will add more documentation here to make it clearer.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Lines 1647 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075732#file2075732line1647>
> >
> > Should this be optional?
> > Is this a regexp or something else? What is the syntax here? What are _ or % wildcards?
This does not need to be optional, the default requiredness of the field makes sure that thrift will always check if this field is set and on the writers will serialize the field only when its possible (null value is not serialized). Will update the documentation
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Lines 1648 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075732#file2075732line1648>
> >
> > Why not just have optional include and exclude patterns instead of a pattern and a boolean?
Thats an interesting thought. Do you think it would be useful for clients to have something like PARAM_KEY LIKE ('includepattern') AND NOT LIKE ('excludepattern')? It should not be too difficult to add to have two separate include and exclude paramKeyPattern.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
> > Lines 1658 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075732#file2075732line1658>
> >
> > Do we need catalog name?
Good point. I will add it.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line56>
> >
> > This shows as an unused import
removed it
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line65>
> >
> > Unused import?
removed it.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 852 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line852>
> >
> > Does this and other new methods belong here or in MetastoreServerUtils?
Its unclear what is the difference between MetaStoreUtils and MetastoreServerUtils? Is MetaStoreUtils going to move to common in the near future? If yes, I can move it to MetastoreServerUtils.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 853 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line853>
> >
> > It would be good to explain what this method actually does converts list of objects to a comma-separated string of stringified objects. Then you can explain the intended use case.
This method is used only in MetastoreDirectSQL class. Moved it back to that class. It was probably a left over from the many iterations of my code changes. Updated the documentations as suggested.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 950 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line950>
> >
> > What is this class?
This class was originally in HMSHandler and used to grouping Partitions based on a common StorageDescriptor. In order to do that, this class is used to generate the hashKey of partitions so that all the partitions having the same hashcode can be grouped together. The hashCode is overridden such that if the sd.cols, input/outputformat, serializationLib and base location is same, it returns the same hashCode so that all such partitions can be grouped together.
I had to move this class from HMSHandler to MetaStoreUtils so that this code could be reused by the new API as well as the previously existing APIs using this grouping logic. I think I can move this to MetaStoreServerUtils, but its unclear what goes into MetaStoreUtils and what goes into MetaStoreServerUtils.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 953 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line953>
> >
> > Do we need this and other fields? Why can't we just use this.sd.outputFormat, etc?
I thought it would be better to keep them as fields since they will be used over and over again in the equals and hashCode method. I changed the implementation so that it removes the fields and calculates the hashCode at the object construction time only once.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 978 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line978>
> >
> > Why do we need an explicit empty constructor?
Yes, its used to represent a unsetSDKey in get_partitionspecs_grouped_by_storage_descriptor which is used when sd is not in the requested list of fields.
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207802
-----------------------------------------------------------
On Aug. 23, 2018, 6:44 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 6:44 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 7ab64eadac7948a7f5077260694926cc5b6e4e4b
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php cc19f2389e7b595722dcc1f3296877a02b20e0a4
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py d098dba100bdfe56aa6ecafb31880098a2d7c6cb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 92424a43feefc8c0db7c91302045437f3afbf274
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 8a4bdd8ed827572f5fd9d291c5454630d84284bd
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 324035a8096a001d3fb170b8640805258d5e2cdd
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 5ae00af564b05ec2720a03072f94c8f8579378a7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 91405b9a334a4b031a5dc7f4a1757a3895bfb386
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 35abd006d41f0eca354123fcfe6f590867f80cac
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 60beab6350d1f4d86bdcf79f5119172117c5ca2e
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
> On Aug. 23, 2018, 6:26 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
> > Lines 852 (patched)
> > <https://reviews.apache.org/r/68395/diff/3/?file=2075744#file2075744line852>
> >
> > Does this and other new methods belong here or in MetastoreServerUtils?
>
> Vihang Karajgaonkar wrote:
> Its unclear what is the difference between MetaStoreUtils and MetastoreServerUtils? Is MetaStoreUtils going to move to common in the near future? If yes, I can move it to MetastoreServerUtils.
Moved them to MetastoreServerUtils.
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207802
-----------------------------------------------------------
On Aug. 24, 2018, 6:15 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2018, 6:15 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 47f96f323ade4e15753d6fd98709b9a882de624d
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 0973f4f3c13554b23ba59b8a1aa1c5a37c094a9e
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 3c0d0a55b1dcca96dca77676873b68e52703715d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e54a7321e2e1e6069a3e598627bc6f6eaed93449
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift feb44d5159f131fae932739923b1a41f5e72e74b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6b660f55aca5b99517447f164339ed92261c9370
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java faf6810420ccf6088a3398711c0c216af722f062
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java ac10da2f3e623c1fe2d1cbb0849af00c4520297b
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java 506d9ab5590a245049f3c4e71324823465a91586
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 6e0d9c1848cdeffc226ff6c55fd49898786c0f4c
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 4937d9d861b13070e7df4f92bf434c40eb1538aa
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/#review207802
-----------------------------------------------------------
Some initial comments.
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1645 (patched)
<https://reviews.apache.org/r/68395/#comment291298>
Please add comment explaining what this is.
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1646 (patched)
<https://reviews.apache.org/r/68395/#comment291300>
does this allow for x.y.z?
Does this work for sd columns and other list fields?
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1647 (patched)
<https://reviews.apache.org/r/68395/#comment291303>
Should this be optional?
Is this a regexp or something else? What is the syntax here? What are _ or % wildcards?
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1648 (patched)
<https://reviews.apache.org/r/68395/#comment291302>
Why not just have optional include and exclude patterns instead of a pattern and a boolean?
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 1658 (patched)
<https://reviews.apache.org/r/68395/#comment291312>
Do we need catalog name?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 56 (patched)
<https://reviews.apache.org/r/68395/#comment291322>
This shows as an unused import
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 65 (patched)
<https://reviews.apache.org/r/68395/#comment291323>
Unused import?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 852 (patched)
<https://reviews.apache.org/r/68395/#comment291319>
Does this and other new methods belong here or in MetastoreServerUtils?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 853 (patched)
<https://reviews.apache.org/r/68395/#comment291321>
It would be good to explain what this method actually does converts list of objects to a comma-separated string of stringified objects. Then you can explain the intended use case.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 950 (patched)
<https://reviews.apache.org/r/68395/#comment291325>
What is this class?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 953 (patched)
<https://reviews.apache.org/r/68395/#comment291326>
Do we need this and other fields? Why can't we just use this.sd.outputFormat, etc?
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
Lines 978 (patched)
<https://reviews.apache.org/r/68395/#comment291324>
Why do we need an explicit empty constructor?
- Alexander Kolbasov
On Aug. 21, 2018, 6:50 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68395/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 6:50 p.m.)
>
>
> Review request for hive, Alexander Kolbasov, Alan Gates, Peter Vary, and Sergey Shelukhin.
>
>
> Bugs: HIVE-20306
> https://issues.apache.org/jira/browse/HIVE-20306
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 7ab64eadac7948a7f5077260694926cc5b6e4e4b
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php cc19f2389e7b595722dcc1f3296877a02b20e0a4
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py d098dba100bdfe56aa6ecafb31880098a2d7c6cb
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 92424a43feefc8c0db7c91302045437f3afbf274
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 8a4bdd8ed827572f5fd9d291c5454630d84284bd
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 324035a8096a001d3fb170b8640805258d5e2cdd
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 5ae00af564b05ec2720a03072f94c8f8579378a7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 91405b9a334a4b031a5dc7f4a1757a3895bfb386
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 35abd006d41f0eca354123fcfe6f590867f80cac
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 60beab6350d1f4d86bdcf79f5119172117c5ca2e
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68395/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 68395: HIVE-20306 : Implement projection spec for
fetching only requested fields from partitions
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68395/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 6:50 p.m.)
Review request for hive, Alexander Kolbasov and Peter Vary.
Changes
-------
Reduced thrift changes only to related files. Fixed test failures.
Bugs: HIVE-20306
https://issues.apache.org/jira/browse/HIVE-20306
Repository: hive-git
Description
-------
HIVE-20306 : Implement projection spec for fetching only requested fields from partitions
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 0ad2a2469e0330e050fdb8983078b80617afbbf1
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsFilterSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsProjectSpec.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsRequest.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPartitionsResponse.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionFilterMode.java PRE-CREATION
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 7ab64eadac7948a7f5077260694926cc5b6e4e4b
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php cc19f2389e7b595722dcc1f3296877a02b20e0a4
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 5ed4f71b1dd947c7d4cbb5c290b393b8cd2ea31d
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote a595732f04af4304974186178377192227bb80fb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py d098dba100bdfe56aa6ecafb31880098a2d7c6cb
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 7fc1e43de03eac1cfe802439ba38f83988299169
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb e0c6c02715dab4d9ad457ec710bcb3159206c6c6
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 92424a43feefc8c0db7c91302045437f3afbf274
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 8a4bdd8ed827572f5fd9d291c5454630d84284bd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 324035a8096a001d3fb170b8640805258d5e2cdd
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 5ae00af564b05ec2720a03072f94c8f8579378a7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 91405b9a334a4b031a5dc7f4a1757a3895bfb386
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 571c789eddfd2b1a27c65c48bdc6dccfafaaf676
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetastoreDirectSqlUtils.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d27224b23580b4662a85c874b657847ed068c9a3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionProjectionEvaluator.java PRE-CREATION
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java b61ee81533930c889f23d2551041055cbdd1a6b2
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 7a0b21b2580d8bb9b256dbc698f125ed15ccdcd3
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 0445cbf9095285bdcde72946f1b6dd9a9a3b9fff
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MSerDeInfo.java 68f07e2569b6531cf3e18919209aed1a17e88bf7
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java 5233bee59220244e89f05b6c4dbf86a2cc6dc9fe
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 0934aeb3a7d5413cacde500a5575e4f676306bd0
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 70a17f51b9b5a9fb0b5640988318fd39a82b895d
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java 35abd006d41f0eca354123fcfe6f590867f80cac
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestGetPartitionsUsingProjection.java PRE-CREATION
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 60beab6350d1f4d86bdcf79f5119172117c5ca2e
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestPartitionProjectionEvaluator.java PRE-CREATION
Diff: https://reviews.apache.org/r/68395/diff/3/
Changes: https://reviews.apache.org/r/68395/diff/2-3/
Testing
-------
Thanks,
Vihang Karajgaonkar