You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/16 20:12:04 UTC
[GitHub] [arrow] andygrove commented on a change in pull request #7133: ARROW-8744: [Rust] handle channel close in parquet batch iterator
andygrove commented on a change in pull request #7133:
URL: https://github.com/apache/arrow/pull/7133#discussion_r426186878
##########
File path: rust/arrow/src/record_batch.rs
##########
@@ -36,7 +36,7 @@ use crate::error::{ArrowError, Result};
/// serialization and computation functions, possibly incremental.
/// See also [CSV reader](crate::csv::Reader) and
/// [JSON reader](crate::json::Reader).
-#[derive(Clone)]
+#[derive(Clone, Debug)]
Review comment:
I'm curious what the debug out would be. Do you have an example?
##########
File path: rust/arrow/src/record_batch.rs
##########
@@ -36,7 +36,7 @@ use crate::error::{ArrowError, Result};
/// serialization and computation functions, possibly incremental.
/// See also [CSV reader](crate::csv::Reader) and
/// [JSON reader](crate::json::Reader).
-#[derive(Clone)]
+#[derive(Clone, Debug)]
Review comment:
I'm curious what the debug output would be. Do you have an example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org