You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/04/30 06:34:17 UTC

[GitHub] [calcite] chunweilei commented on a change in pull request #1191: [CALCITE-3039] Why MinFloat use Math::min while MinDouble use Math::m…

chunweilei commented on a change in pull request #1191: [CALCITE-3039] Why MinFloat use Math::min while MinDouble use Math::m…
URL: https://github.com/apache/calcite/pull/1191#discussion_r279626783
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/interpreter/AggregateNode.java
 ##########
 @@ -536,7 +536,7 @@ public MinFloat() {
    */
   public static class MinDouble extends NumericComparison<Double> {
     public MinDouble() {
-      super(Double.MAX_VALUE, Math::max);
+      super(Double.MAX_VALUE, Math::min);
     }
   }
 
 Review comment:
   Could you please add a test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services