You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/09 12:11:06 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #228: [YUNIKORN-481] deadlock when removing allocation ask
codecov[bot] commented on pull request #228:
URL: https://github.com/apache/incubator-yunikorn-core/pull/228#issuecomment-741731604
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228?src=pr&el=desc) (4b7bed9) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/9f0f1ceb479b7949c851b8878fed88d746f5143d?el=desc) (9f0f1ce) will **increase** coverage by `0.01%`.
> The diff coverage is `73.33%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 63.08% 63.09% +0.01%
==========================================
Files 59 59
Lines 4857 4875 +18
==========================================
+ Hits 3064 3076 +12
- Misses 1651 1657 +6
Partials 142 142
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/node.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `83.33% <0.00%> (-1.98%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `64.90% <66.66%> (+<0.01%)` | :arrow_up: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `77.77% <100.00%> (ø)` | |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `55.30% <100.00%> (+1.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228?src=pr&el=footer). Last update [9f0f1ce...4b7bed9](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org