You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by rob05c <gi...@git.apache.org> on 2017/02/28 20:54:07 UTC
[GitHub] incubator-trafficcontrol pull request #323: Move Traffic Monitor 2.0 Data Re...
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/323
Move Traffic Monitor 2.0 Data Request to its own package
Splits a 1200-line file.
This is dependent on changesets in PR #320 and should not be merged before it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol tm2-datareq
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #323
----
commit a74af136eb972924f70dd272886a181bb5340091
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-27T22:30:27Z
Add TM2 Stats endpoint cache poll 95th percentile
commit 032381bece97572697030511001017d946b9d75e
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-27T22:53:58Z
Change TM2 to poll slightly under targets
commit 746d642af6b7fd98a5122bf0c7f1da12f29257dc
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-27T23:14:37Z
Fix TM2 global variable to be a safe local
This wasn't technically a thread safety issue, because the integer was
only ever checked as a boolean. But it's a dangerous precedent, as in
most cases this design pattern would be unsafe. Changing it to a local
variable, and making the function 'pure', is generally safer, easier
to understand, and doesn't give anyone the idea that pattern is okay.
commit 3e8365fd5248ecdba13fd763395d93ca29ac9efb
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-28T17:42:37Z
Fix TM2 incorrect comment
commit 6c8cac392e88685c4458f9a342e3938cb72739eb
Author: Robert Butts <ro...@gmail.com>
Date: 2017-02-28T20:44:35Z
Move TM2 datarequest to its own package
This breaks up a 1200-line file, into one file per endpoint.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #323: Move Traffic Monitor 2.0 Data Re...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/323#discussion_r103846810
--- Diff: traffic_monitor_golang/traffic_monitor/datareq/bandwidth.go ---
@@ -0,0 +1,18 @@
+package datareq
--- End diff --
you are missing the license file in a lot of these files, can you please add it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #323: Move Traffic Monitor 2.0 Data Re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #323: Move Traffic Monitor 2.0 Data Request t...
Posted by rob05c <gi...@git.apache.org>.
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/323
@dneuman64 Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #323: Move Traffic Monitor 2.0 Data Request t...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/323
Can you please rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---