You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cclauss <gi...@git.apache.org> on 2018/07/03 07:04:07 UTC

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

Github user cclauss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20838#discussion_r199701953
  
    --- Diff: python/pyspark/sql/conf.py ---
    @@ -59,7 +62,7 @@ def unset(self, key):
     
         def _checkType(self, obj, identifier):
             """Assert that an object is of type str."""
    -        if not isinstance(obj, str) and not isinstance(obj, unicode):
    +        if not isinstance(obj, basestring):
    --- End diff --
    
    Is there an issue here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org