You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/02/02 07:44:04 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #19389: [fix][bug] Fix concurrency bug in PersistentTopicsBase#internalGetReplicatedSubscriptionStatus
lhotari opened a new pull request, #19389:
URL: https://github.com/apache/pulsar/pull/19389
### Motivation
There's a concurrency bug in PersistentTopicsBase#internalGetReplicatedSubscriptionStatus.
A `java.util.HashMap` is used to collect results of concurrent asynchronous method calls.
### Modifications
- use `ConcurrentHashMap` instead of `java.util.HashMap`
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #19389: [fix][broker] Fix concurrency bug in PersistentTopicsBase#internalGetReplicatedSubscriptionStatus
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #19389:
URL: https://github.com/apache/pulsar/pull/19389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #19389: [fix][broker] Fix concurrency bug in PersistentTopicsBase#internalGetReplicatedSubscriptionStatus
Posted by "nicoloboschi (via GitHub)" <gi...@apache.org>.
nicoloboschi commented on code in PR #19389:
URL: https://github.com/apache/pulsar/pull/19389#discussion_r1094372398
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -5220,7 +5220,7 @@ protected void internalGetReplicatedSubscriptionStatus(AsyncResponse asyncRespon
.thenAccept(partitionMetadata -> {
if (partitionMetadata.partitions > 0) {
List<CompletableFuture<Void>> futures = new ArrayList<>(partitionMetadata.partitions);
- Map<String, Boolean> status = new HashMap<>();
+ Map<String, Boolean> status = new ConcurrentHashMap<>(partitionMetadata.partitions);
Review Comment:
the initial capacity of the ConcurrentHashMap is subject to the load factor. I'd leave it with the default capacity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #19389: [fix][broker] Fix concurrency bug in PersistentTopicsBase#internalGetReplicatedSubscriptionStatus
Posted by "AnonHxy (via GitHub)" <gi...@apache.org>.
AnonHxy commented on PR #19389:
URL: https://github.com/apache/pulsar/pull/19389#issuecomment-1413450657
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org