You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/23 13:44:05 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #930: Add some additional asserts in `utils::from_plan`
alamb opened a new pull request #930:
URL: https://github.com/apache/arrow-datafusion/pull/930
# Which issue does this PR close?
Re: https://github.com/apache/arrow-datafusion/issues/917
Built on https://github.com/apache/arrow-datafusion/pull/929, so draft until that is merged
# Rationale for this change
https://github.com/apache/arrow-datafusion/issues/917 was due to mishandling a newly added `LogicalPlan` node in `utils::from_plan`
# What changes are included in this PR?
1. Make it harder to introduce such bugs in the future by adding asserts
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #930: Add some additional asserts in `utils::from_plan`
Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #930:
URL: https://github.com/apache/arrow-datafusion/pull/930#discussion_r695622047
##########
File path: datafusion/src/optimizer/utils.rs
##########
@@ -206,10 +206,28 @@ pub fn from_plan(
input: Arc::new(inputs[0].clone()),
})
}
+ LogicalPlan::Explain { .. } => {
+ // Explain shoudl be handled specially in the optimizers;
Review comment:
Small typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #930: Add some additional asserts in `utils::from_plan`
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #930:
URL: https://github.com/apache/arrow-datafusion/pull/930#discussion_r695895332
##########
File path: datafusion/src/optimizer/utils.rs
##########
@@ -206,10 +206,28 @@ pub fn from_plan(
input: Arc::new(inputs[0].clone()),
})
}
+ LogicalPlan::Explain { .. } => {
+ // Explain shoudl be handled specially in the optimizers;
Review comment:
🦅 👁️
Fix in https://github.com/apache/arrow-datafusion/pull/945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #930: Add some additional asserts in `utils::from_plan`
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #930:
URL: https://github.com/apache/arrow-datafusion/pull/930#issuecomment-905377532
fyi @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #930: Add some additional asserts in `utils::from_plan`
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #930:
URL: https://github.com/apache/arrow-datafusion/pull/930#issuecomment-905381906
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #930: Add some additional asserts in `utils::from_plan`
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #930:
URL: https://github.com/apache/arrow-datafusion/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org