You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2016/03/03 16:54:27 UTC

Review Request 44339: Disabled Appc simple fetch test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44339/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Due to dependency on 'curl'.


Diffs
-----

  src/tests/containerizer/provisioner_appc_tests.cpp 032c555e571bd6196b495ba0d6e8b56336ea4a10 

Diff: https://reviews.apache.org/r/44339/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Re: Review Request 44339: Disabled Appc simple fetch test.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44339/#review121883
-----------------------------------------------------------



I commited a fix using the CURL test filter.

- Jie Yu


On March 3, 2016, 3:54 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44339/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 3:54 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Due to dependency on 'curl'.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 032c555e571bd6196b495ba0d6e8b56336ea4a10 
> 
> Diff: https://reviews.apache.org/r/44339/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 44339: Disabled Appc simple fetch test.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44339/#review121871
-----------------------------------------------------------



Isn't there already a CurlFilter for tests?

- Joerg Schad


On March 3, 2016, 3:54 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44339/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 3:54 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Due to dependency on 'curl'.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 032c555e571bd6196b495ba0d6e8b56336ea4a10 
> 
> Diff: https://reviews.apache.org/r/44339/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>