You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/11/09 10:29:31 UTC

[GitHub] [myfaces-homepage] bohmber opened a new pull request #1: Improved MyFaces Homepage

bohmber opened a new pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1


   Fixed Tobago pages and some other pages
   Simplify menu
   Added required ASF pages


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] bohmber commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-723944816


   The menu structure should be better. 
   And I don't like a menu item for every old version. 
   It will not scale for the MyFaces homepage.
   What about this? An old Version page and pages for the active versions.
   
   I changed the Concept page. The Concept page doesn't include the concept directly. Better now? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-724063796


   unsure
   its more a mix of internal concepts, improvements and how JSF works (like immediate)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] bohmber commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-723954648


   Ok i will play with the version pages a little bit. There might be a better solution


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] bohmber commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-724050353


   How about this?
   
   https://bohmber.github.io/myfaces-homepage/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-724053485


   thats ok for me, just 2.2 is doubled now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] bohmber commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-724057342


   I would like to rename concepts to improvements? Just an idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] bohmber merged pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
bohmber merged pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-723929364


   The items below "core concepts" are to long now:
   Apache MyFaces Core Concepts - View Pooling
   
   that doesnt look good, same for versions.
   We are already under Core / Versions, why does the submenus are called "Apache MyFaces Core 1.1"?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-723947876


   concept looks better now.
   
   hmm, really unsure. 
   maybe all versions in one single view and outsource the config section, to have one view for each version with just config stuff?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] bohmber commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-724076607


   At the moment i'm fine with concepts. Can we merge now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko edited a comment on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko edited a comment on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-723930357


   Also the core concepts page is to fat now for me, it was by design to put it in different views as e.g. viewpooling or immediate are really really big.
   But i like the menu structure itself better as they expand lazy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] bohmber commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
bohmber commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-724055344


   fixed 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-724081087


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko commented on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-723930357


   Also the core concepts page is to fat now for me, it was by design to put it in different views as e.g. viewpooling or immediate are really really big.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces-homepage] tandraschko edited a comment on pull request #1: Improved MyFaces Homepage

Posted by GitBox <gi...@apache.org>.
tandraschko edited a comment on pull request #1:
URL: https://github.com/apache/myfaces-homepage/pull/1#issuecomment-723930357


   Also the core concepts page is to fat now for me, it was by design to put it in different views as e.g. viewpooling or immediate are really really big.
   Same for versions actually. If you use ctrl+f for search for a init param, you get any version. I think seperated views are reallly better here.
   But i like the menu structure itself better as they expand lazy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org