[GitHub] soboko opened a new pull request #6702: Fix for Airbnb bug PRODUCT-62223 - Text field to edit SQL snippet of a metric is not large enough for entire snippet

[GitBox <gi...@apache.org>]

soboko opened a new pull request #6702: Fix for Airbnb bug PRODUCT-62223 - Text field to edit SQL snippet of a metric is not large enough for entire snippet
URL: https://github.com/apache/incubator-superset/pull/6702
 
 
   This PR widens the field slightly and allows for (application of classes to) and (multiline editing of) EditableTitles in general. Also moves some styling from code to CSS.
   
   Note - when it comes to CSS I'm not sure how everything is organized in SuperSet, so input is definitely welcomed. I'm also not 100% happy with the solution of setting the `textarea`'s size in code, but I couldn't figure out a way to do this in pure CSS, since the height of the `textarea` is dependent on how many lines the text being edited is (which can't really be determined until the label renders). If you have any ideas, LMK.
   
   to: @williaster @michellethomas @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org