[GitHub] [superset] stevetracvc commented on a change in pull request #19383: feat: truncate long values in table viz, a per-column setting

[GitBox <gi...@apache.org>]

stevetracvc commented on a change in pull request #19383:
URL: https://github.com/apache/superset/pull/19383#discussion_r838924053



##########
File path: superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/ColumnConfigControl/constants.tsx
##########
@@ -191,12 +204,14 @@ export const DEFAULT_CONFIG_FORM_LAYOUT: ColumnConfigFormLayout = {
       'columnWidth',
       { name: 'horizontalAlign', override: { defaultValue: 'left' } },
     ],
+    ['truncateLongCells'],
     ['d3TimeFormat'],
   ],
   [GenericDataType.BOOLEAN]: [
     [
       'columnWidth',
       { name: 'horizontalAlign', override: { defaultValue: 'left' } },
     ],
+    ['truncateLongCells'],

Review comment:
       So I originally was thinking that too and left it out for everything except string, but thought that it might be better to allow (since it is off by default anyway). Dates could be formatted in a way that's wider than what you want. I dunno, I'll leave it up to you. I haven't used it for anything other than string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org