You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/09/17 13:55:11 UTC

[GitHub] [accumulo] Manno15 commented on a change in pull request #1706: Related #1664. Allow Candidate batch size to be user configurable

Manno15 commented on a change in pull request #1706:
URL: https://github.com/apache/accumulo/pull/1706#discussion_r490265322



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -568,8 +568,8 @@
   // accumulo garbage collector properties
   GC_PREFIX("gc.", null, PropertyType.PREFIX,
       "Properties in this category affect the behavior of the accumulo garbage collector."),
-  GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "4000000", PropertyType.COUNT,
-          "The batch size used for garbage collection. The default is effectively 8MB"),
+  GC_CANDIDATE_BATCH_SIZE("gc.candidate.batch.size", "8m", PropertyType.BYTES,

Review comment:
       Fair, I had it capitalized but I didn't like the way it looked and saw we had a `1g` somewhere. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org