[GitHub] [kafka] divijvaidya commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on PR #13312:
URL: https://github.com/apache/kafka/pull/13312#issuecomment-1495898660

   > There is a hollow VarInt implementation here that is similarly unrolled on the `write` path but is I think a little easier to read!
   > 
   > https://github.com/Netflix/hollow/blob/master/hollow/src/main/java/com/netflix/hollow/core/memory/encoding/VarInt.java#L51-L134
   > 
   > @dkoszewnik -- do you have an opinion on this? I'm sure you've experimented with multiple implementations.
   
   @jasonk000 Hollow's implementation is based on assumption that system is little endian but JVM defaults to big endian. Hence, it would not be compatible with Apache Kafka code directly. 
   
   
   
   > @divijvaidya The following is also interesting [astei/varint-writing-showdown#1](https://github.com/astei/varint-writing-showdown/issues/1)
   
   @ijuma I tested this but it was much slower than rest of the implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org