[GitHub] [doris] freemandealer commented on a diff in pull request #15839: [Feature] support segment builder tool

["freemandealer (via GitHub)" <gi...@apache.org>]

freemandealer commented on code in PR #15839:
URL: https://github.com/apache/doris/pull/15839#discussion_r1102286757


##########
be/src/olap/tablet_manager.h:
##########
@@ -151,7 +150,7 @@ class TabletManager {
     //        Status::Error<UNINITIALIZED>(), if not inited
     Status _add_tablet_unlocked(TTabletId tablet_id, const TabletSharedPtr& tablet,

Review Comment:
   As a gentle reminder, strip the '_' for the public method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org