You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/12 07:36:39 UTC
Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4165
https://issues.apache.org/jira/browse/MESOS-4165
Repository: mesos
Description
-------
Speed up MasterTest.MasterInfoOnReElection.
Diffs
-----
src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
Diff: https://reviews.apache.org/r/43515/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/#review128378
-----------------------------------------------------------
Ship it!
I'll adjust the wording and will commit shortly.
- Alexander Rukletsov
On April 9, 2016, 6:19 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43515/
> -----------------------------------------------------------
>
> (Updated April 9, 2016, 6:19 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4165
> https://issues.apache.org/jira/browse/MESOS-4165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterTest.MasterInfoOnReElection by advance allocation
> interval.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491
>
> Diff: https://reviews.apache.org/r/43515/diff/
>
>
> Testing
> -------
>
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" --gtest_repeat=200 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/
-----------------------------------------------------------
(Updated April 9, 2016, 6:19 a.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Changes
-------
Update description.
Bugs: MESOS-4165
https://issues.apache.org/jira/browse/MESOS-4165
Repository: mesos
Description (updated)
-------
Speed up MasterTest.MasterInfoOnReElection by advance allocation
interval.
Diffs
-----
src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491
Diff: https://reviews.apache.org/r/43515/diff/
Testing
-------
Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" --gtest_repeat=200 --gtest_break_on_failure
```
Thanks,
haosdent huang
Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/
-----------------------------------------------------------
(Updated April 8, 2016, 3:43 p.m.)
Review request for mesos, Alexander Rukletsov and Ben Mahler.
Bugs: MESOS-4165
https://issues.apache.org/jira/browse/MESOS-4165
Repository: mesos
Description (updated)
-------
Speed up MasterTest.MasterInfoOnReElection by advance allocation interval.
Diffs (updated)
-----
src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491
Diff: https://reviews.apache.org/r/43515/diff/
Testing (updated)
-------
Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" --gtest_repeat=200 --gtest_break_on_failure
```
Thanks,
haosdent huang
Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.
Posted by haosdent huang <ha...@gmail.com>.
> On April 8, 2016, 2:19 p.m., Alexander Rukletsov wrote:
> > src/tests/master_tests.cpp, line 1036
> > <https://reviews.apache.org/r/43515/diff/1/?file=1240611#file1240611line1036>
> >
> > Why do you settle?
Not need settle here. My bad. Remove it just now.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/#review127788
-----------------------------------------------------------
On April 8, 2016, 3:43 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43515/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 3:43 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
>
>
> Bugs: MESOS-4165
> https://issues.apache.org/jira/browse/MESOS-4165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterTest.MasterInfoOnReElection by advance allocation interval.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491
>
> Diff: https://reviews.apache.org/r/43515/diff/
>
>
> Testing
> -------
>
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" --gtest_repeat=200 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43515/#review127788
-----------------------------------------------------------
Could you please run the test in repetition?
src/tests/master_tests.cpp (line 1036)
<https://reviews.apache.org/r/43515/#comment191176>
Why do you settle?
src/tests/master_tests.cpp (line 1037)
<https://reviews.apache.org/r/43515/#comment191174>
Let's extract this value from master flags: it's more reliable if someone decides to change interval through flags in this test.
src/tests/master_tests.cpp (line 1042)
<https://reviews.apache.org/r/43515/#comment191175>
Move it up after `advance()`?
- Alexander Rukletsov
On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43515/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 6:36 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4165
> https://issues.apache.org/jira/browse/MESOS-4165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterTest.MasterInfoOnReElection.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303
>
> Diff: https://reviews.apache.org/r/43515/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>