You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/18 17:01:41 UTC
[jira] [Commented] (BEAM-1992) Count.perElement javadoc refers to
Count.PerElement, but Count.PerElement is private
[ https://issues.apache.org/jira/browse/BEAM-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973068#comment-15973068 ]
ASF GitHub Bot commented on BEAM-1992:
--------------------------------------
GitHub user wtanaka opened a pull request:
https://github.com/apache/beam/pull/2577
[BEAM-1992] Move Count.PerElement javadoc to a public place
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wtanaka/beam BEAM-1992
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2577.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2577
----
commit 0413593e6b6cb54594f684c21173a6b5ad0aedd7
Author: wtanaka.com <wt...@yahoo.com>
Date: 2017-04-18T07:57:10Z
[BEAM-1992] Move Count.PerElement javadoc to a public place
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----
> Count.perElement javadoc refers to Count.PerElement, but Count.PerElement is private
> ------------------------------------------------------------------------------------
>
> Key: BEAM-1992
> URL: https://issues.apache.org/jira/browse/BEAM-1992
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Wesley Tanaka
> Assignee: Wesley Tanaka
> Priority: Minor
>
> https://beam.apache.org/documentation/sdks/javadoc/0.6.0/org/apache/beam/sdk/transforms/Count.html#perElement--
> says:
> "See Count.PerElement for more details."
> But Count.PerElement isn't in https://beam.apache.org/documentation/sdks/javadoc/0.6.0/allclasses-frame.html -- probably since https://github.com/apache/beam/commit/9957c895b1b1c3e491f288d17e70445c9864742a#diff-c225a00920a8d3505eb15163cb8c573bR108
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)