You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Lars Michele (JIRA)" <ji...@apache.org> on 2012/09/27 20:43:07 UTC
[jira] [Created] (JCR-3434) EventJournal#skipTo() broken
Lars Michele created JCR-3434:
---------------------------------
Summary: EventJournal#skipTo() broken
Key: JCR-3434
URL: https://issues.apache.org/jira/browse/JCR-3434
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-core
Affects Versions: 2.5.2, 2.4.3, 2.2.12
Reporter: Lars Michele
There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:
Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
===================================================================
--- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
+++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
@@ -135,7 +135,7 @@
// get skip map for this journal
SortedMap<Long, Long> skipMap = getSkipMap();
synchronized (skipMap) {
- SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
+ SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
if (!head.isEmpty()) {
eventBundleBuffer.clear();
lastRevision = head.get(head.lastKey());
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (JCR-3434) EventJournal#skipTo() broken
Posted by "Unico Hommes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Unico Hommes reassigned JCR-3434:
---------------------------------
Assignee: Unico Hommes
> EventJournal#skipTo() broken
> ----------------------------
>
> Key: JCR-3434
> URL: https://issues.apache.org/jira/browse/JCR-3434
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.12, 2.4.3, 2.5.2
> Reporter: Lars Michele
> Assignee: Unico Hommes
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:
> Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
> ===================================================================
> --- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
> +++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
> @@ -135,7 +135,7 @@
> // get skip map for this journal
> SortedMap<Long, Long> skipMap = getSkipMap();
> synchronized (skipMap) {
> - SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
> + SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
> if (!head.isEmpty()) {
> eventBundleBuffer.clear();
> lastRevision = head.get(head.lastKey());
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3434) EventJournal#skipTo() broken
Posted by "Unico Hommes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Unico Hommes resolved JCR-3434.
-------------------------------
Resolution: Fixed
> EventJournal#skipTo() broken
> ----------------------------
>
> Key: JCR-3434
> URL: https://issues.apache.org/jira/browse/JCR-3434
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.12, 2.4.3, 2.5.2
> Reporter: Lars Michele
> Assignee: Unico Hommes
> Fix For: 2.2.13, 2.4.4, 2.5.3
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:
> Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
> ===================================================================
> --- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
> +++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
> @@ -135,7 +135,7 @@
> // get skip map for this journal
> SortedMap<Long, Long> skipMap = getSkipMap();
> synchronized (skipMap) {
> - SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
> + SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
> if (!head.isEmpty()) {
> eventBundleBuffer.clear();
> lastRevision = head.get(head.lastKey());
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3434) EventJournal#skipTo() broken
Posted by "Unico Hommes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466157#comment-13466157 ]
Unico Hommes commented on JCR-3434:
-----------------------------------
Backported to branch 2.2 in revision 1391770.
> EventJournal#skipTo() broken
> ----------------------------
>
> Key: JCR-3434
> URL: https://issues.apache.org/jira/browse/JCR-3434
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.12, 2.4.3, 2.5.2
> Reporter: Lars Michele
> Assignee: Unico Hommes
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:
> Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
> ===================================================================
> --- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
> +++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
> @@ -135,7 +135,7 @@
> // get skip map for this journal
> SortedMap<Long, Long> skipMap = getSkipMap();
> synchronized (skipMap) {
> - SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
> + SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
> if (!head.isEmpty()) {
> eventBundleBuffer.clear();
> lastRevision = head.get(head.lastKey());
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3434) EventJournal#skipTo() broken
Posted by "Unico Hommes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Unico Hommes updated JCR-3434:
------------------------------
Fix Version/s: 2.5.3
2.4.4
2.2.13
> EventJournal#skipTo() broken
> ----------------------------
>
> Key: JCR-3434
> URL: https://issues.apache.org/jira/browse/JCR-3434
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.12, 2.4.3, 2.5.2
> Reporter: Lars Michele
> Assignee: Unico Hommes
> Fix For: 2.2.13, 2.4.4, 2.5.3
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:
> Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
> ===================================================================
> --- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
> +++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
> @@ -135,7 +135,7 @@
> // get skip map for this journal
> SortedMap<Long, Long> skipMap = getSkipMap();
> synchronized (skipMap) {
> - SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
> + SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
> if (!head.isEmpty()) {
> eventBundleBuffer.clear();
> lastRevision = head.get(head.lastKey());
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3434) EventJournal#skipTo() broken
Posted by "Unico Hommes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466155#comment-13466155 ]
Unico Hommes commented on JCR-3434:
-----------------------------------
Committed to trunk in revision 1391767.
> EventJournal#skipTo() broken
> ----------------------------
>
> Key: JCR-3434
> URL: https://issues.apache.org/jira/browse/JCR-3434
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.12, 2.4.3, 2.5.2
> Reporter: Lars Michele
> Assignee: Unico Hommes
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:
> Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
> ===================================================================
> --- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
> +++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
> @@ -135,7 +135,7 @@
> // get skip map for this journal
> SortedMap<Long, Long> skipMap = getSkipMap();
> synchronized (skipMap) {
> - SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
> + SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
> if (!head.isEmpty()) {
> eventBundleBuffer.clear();
> lastRevision = head.get(head.lastKey());
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3434) EventJournal#skipTo() broken
Posted by "Unico Hommes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466156#comment-13466156 ]
Unico Hommes commented on JCR-3434:
-----------------------------------
Backported to branch 2.4 in revision 1391769.
> EventJournal#skipTo() broken
> ----------------------------
>
> Key: JCR-3434
> URL: https://issues.apache.org/jira/browse/JCR-3434
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.2.12, 2.4.3, 2.5.2
> Reporter: Lars Michele
> Assignee: Unico Hommes
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> There is a little typo in the implementation of EventJournal#skipTo method which makes it pretty useless because it is skipping always to the last EventBundle. I attach the patch inlined because it is really small:
> Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
> ===================================================================
> --- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (revision 1391154)
> +++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java (working copy)
> @@ -135,7 +135,7 @@
> // get skip map for this journal
> SortedMap<Long, Long> skipMap = getSkipMap();
> synchronized (skipMap) {
> - SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
> + SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
> if (!head.isEmpty()) {
> eventBundleBuffer.clear();
> lastRevision = head.get(head.lastKey());
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira