svn commit: r1730973 - in /myfaces/tobago/branches/tobago-3.0.x: tobago-core/src/main/java/org/apache/myfaces/tobago/layout/ tobago-core/src/test/java/org/apache/myfaces/tobago/layout/ tobago-extension/tobago-sandbox/src/main/java/org/apache/myfaces/to...

[lo...@apache.org]

Author: lofwyr
Date: Wed Feb 17 23:09:31 2016
New Revision: 1730973

URL: http://svn.apache.org/viewvc?rev=1730973&view=rev
Log:
TOBAGO-1501: Refactoring: using further enums
* simplify name tests

Added:
    myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/layout/OrientationUnitTest.java
Modified:
    myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/layout/Orientation.java
    myfaces/tobago/branches/tobago-3.0.x/tobago-extension/tobago-sandbox/src/main/java/org/apache/myfaces/tobago/internal/taglib/sandbox/SplitLayoutTagDeclaration.java

Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/layout/Orientation.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/layout/Orientation.java?rev=1730973&r1=1730972&r2=1730973&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/layout/Orientation.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/main/java/org/apache/myfaces/tobago/layout/Orientation.java Wed Feb 17 23:09:31 2016
@@ -30,11 +30,11 @@ public enum Orientation {
   /**
    * Internal constant to use in annotations. Please use {@link Orientation#horizontal}
    */
-  public static final String STRING_HORIZONTAL = "horizontal";
+  public static final String HORIZONTAL = "horizontal";
 
   /**
    * Internal constant to use in annotations. Please use {@link Orientation#horizontal}
    */
-  public static final String STRING_VERTICAL = "vertical";
+  public static final String VERTICAL = "vertical";
 
 }

Added: myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/layout/OrientationUnitTest.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/layout/OrientationUnitTest.java?rev=1730973&view=auto
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/layout/OrientationUnitTest.java (added)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-core/src/test/java/org/apache/myfaces/tobago/layout/OrientationUnitTest.java Wed Feb 17 23:09:31 2016
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.myfaces.tobago.layout;
+
+import org.apache.myfaces.tobago.util.EnumUnitTest;
+import org.junit.Test;
+
+public class OrientationUnitTest extends EnumUnitTest {
+
+  @Test
+  public void testNames() throws IllegalAccessException, NoSuchFieldException {
+    testNames(Orientation.class);
+  }
+}
\ No newline at end of file

Modified: myfaces/tobago/branches/tobago-3.0.x/tobago-extension/tobago-sandbox/src/main/java/org/apache/myfaces/tobago/internal/taglib/sandbox/SplitLayoutTagDeclaration.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/branches/tobago-3.0.x/tobago-extension/tobago-sandbox/src/main/java/org/apache/myfaces/tobago/internal/taglib/sandbox/SplitLayoutTagDeclaration.java?rev=1730973&r1=1730972&r2=1730973&view=diff
==============================================================================
--- myfaces/tobago/branches/tobago-3.0.x/tobago-extension/tobago-sandbox/src/main/java/org/apache/myfaces/tobago/internal/taglib/sandbox/SplitLayoutTagDeclaration.java (original)
+++ myfaces/tobago/branches/tobago-3.0.x/tobago-extension/tobago-sandbox/src/main/java/org/apache/myfaces/tobago/internal/taglib/sandbox/SplitLayoutTagDeclaration.java Wed Feb 17 23:09:31 2016
@@ -62,7 +62,7 @@ public interface SplitLayoutTagDeclarati
   @TagAttribute(required = true)
   @UIComponentTagAttribute(
       type = "org.apache.myfaces.tobago.layout.Orientation",
-      allowedValues = {Orientation.STRING_HORIZONTAL, Orientation.STRING_VERTICAL})
+      allowedValues = {Orientation.HORIZONTAL, Orientation.VERTICAL})
   void setOrientation(String orientation);
 
   /**