You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/14 05:42:26 UTC
[GitHub] [spark] huaxingao commented on a change in pull request #35202: [SPARK-37479][SQL] Migrate DROP NAMESPACE to use V2 command by default
huaxingao commented on a change in pull request #35202:
URL: https://github.com/apache/spark/pull/35202#discussion_r784519897
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropNamespaceExec.scala
##########
@@ -46,9 +46,17 @@ case class DropNamespaceExec(
}
}
- if (!nsCatalog.dropNamespace(ns)) {
- throw QueryCompilationErrors.cannotDropNonemptyNamespaceError(namespace)
+ nsCatalog match {
+ case v2SessionCatalog: V2SessionCatalog =>
+ if (!v2SessionCatalog.dropNamespaceWithCascadeMode(ns, cascade)) {
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org