[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #702: [MINOR] Removed unused methods and variable

["smallzhongfeng (via GitHub)" <gi...@apache.org>]

smallzhongfeng commented on PR #702:
URL: https://github.com/apache/incubator-uniffle/pull/702#issuecomment-1463331309

   > Could you take a look at the flaky test? https://github.com/apache/incubator-uniffle/actions/runs/4373629552/jobs/7652043074 I see the logs in this test case. <img alt="企业微信截图_504825fd-4f91-4e7e-ad85-ee841a79d9ba" width="699" src="https://user-images.githubusercontent.com/8159038/224235835-3035f5d6-1784-44f3-bf3b-4970b4e1b2d0.png">
   > 
   > But I don't see similar logs when I run them in my local machine.
   
   Because we removed the hdfs-minimcluster, the paths of path1 and path2 were not created, and this error was thrown. But I do not affect the logic of their choice of path, because the strategy of `IO_SAMPLE` compares the time of reading and writing hdfs files. Because the creation of hdfs paths fails, the number of apps written in each path will be compared, and the logic of path selection will not be affected. This GA error should not be the cause of the failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org