You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/14 13:57:10 UTC

[GitHub] [pulsar] HQebupt opened a new pull request, #17650: [fix][doc]correct the explanation for invalidateEntries in the EntryCache

HQebupt opened a new pull request, #17650:
URL: https://github.com/apache/pulsar/pull/17650

   ### Motivation
   The method `invalidateEntries` aims to remove from cache all the entries related to a ledger up to lastPosition. And the `lastPosition` is non-inclusive as opposed to its explanation. see L173.
   
   https://github.com/apache/pulsar/blob/e771fc885afe2cc3807fa491af2510a25377ed57/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/RangeEntryCacheImpl.java#L161-L173
   
   ### Modifications
   correct the explanation for `invalidateEntries`
   
   ### Verifying this change
   
   - [x]  Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   ### Does this pull request potentially affect one of the following parts:
   
   If `yes` was chosen, please highlight the changes
   
   - Dependencies (does it add or upgrade a dependency): (no)
   - The public API: (no)
   - The schema: (no)
   - The default values of configurations: (no)
   - The wire protocol: (no)
   - The rest endpoints: (no)
   - The admin cli options: (no)
   - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs?
   
   - [ ] `doc-required`
   
   - [ ] `doc-not-needed`
   
   - [x] `doc`
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #17650: [fix][doc]correct the explanation for invalidateEntries in the EntryCache

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17650:
URL: https://github.com/apache/pulsar/pull/17650#issuecomment-1247484351

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy merged pull request #17650: [fix][doc]correct the explanation for invalidateEntries in the EntryCache

Posted by GitBox <gi...@apache.org>.
AnonHxy merged PR #17650:
URL: https://github.com/apache/pulsar/pull/17650


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org