You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by lewijw <gi...@git.apache.org> on 2016/12/21 21:17:52 UTC
[GitHub] httpcore pull request #32: HTTPCORE-439: Basicheader override of equals and ...
GitHub user lewijw opened a pull request:
https://github.com/apache/httpcore/pull/32
HTTPCORE-439: Basicheader override of equals and hashcode
When removing headers from a HeaderGroup, the header is only removed if the header you are trying to remove is an object in the header list. It seems it would be better if headers were removed that matched the name and value of one of the objects in the list. To accomplish this, I have overridden the equals and hashCode methods in BasicHeader.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewijw/httpcore basicheader_override_of_equals_and_hashcode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcore/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit acd17adfa2a57b4eb50e231ca4565100b1c402e4
Author: John W. Lewis <jo...@sas.com>
Date: 2016-12-21T21:12:19Z
HTTPCORE-439: Contribute BasicHeader override of equals and hashcode
commit b197d174764f66e61e55edb118594db3747a8a6c
Author: John W. Lewis <jo...@sas.com>
Date: 2016-12-21T21:12:19Z
HTTPCORE-439: Contribute BasicHeader override of equals and hashcode
commit 89c1a97d12e6d41fddc919a4f6d269ef3e8e1197
Author: John W. Lewis <jo...@sas.com>
Date: 2016-12-21T21:15:53Z
Merge branch 'basicheader_override_of_equals_and_hashcode' of https://github.com/lewijw/httpcore into basicheader_override_of_equals_and_hashcode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore pull request #32: HTTPCORE-439: Basicheader override of equals and ...
Posted by lewijw <gi...@git.apache.org>.
Github user lewijw closed the pull request at:
https://github.com/apache/httpcore/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore issue #32: HTTPCORE-439: Basicheader override of equals and hashcod...
Posted by lewijw <gi...@git.apache.org>.
Github user lewijw commented on the issue:
https://github.com/apache/httpcore/pull/32
Thanks for making the changes and expediting this to get it in the alpha2 release. I got rid of some redundant test code. I am also assuming these headers are equal (the sensitivity is of no concern with equality):
final Header header = new BasicHeader("name", "value", true);
final Header header2 = new BasicHeader("name", "value", false);
When is the alpha2 release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore issue #32: HTTPCORE-439: Basicheader override of equals and hashcod...
Posted by lewijw <gi...@git.apache.org>.
Github user lewijw commented on the issue:
https://github.com/apache/httpcore/pull/32
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore issue #32: HTTPCORE-439: Basicheader override of equals and hashcod...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcore/pull/32
Committed to SVN trunk
URL: http://svn.apache.org/viewvc?rev=1775806&view=rev
Please review and close.
PS: The 5.0-alpha2 release vote is ongoing. However due to the time of the year I cannot rule out its failure due to insufficient binding votes. If I have to cut another RC your changes will get picked up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcore issue #32: HTTPCORE-439: Basicheader override of equals and hashcod...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the issue:
https://github.com/apache/httpcore/pull/32
Committed to SVN trunk with some changes
http://svn.apache.org/viewvc?rev=1775588&view=rev
Please review and close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org