[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #587: DISPATCH-1445 - Modeled saslPassword to be more or less in line with …
URL: https://github.com/apache/qpid-dispatch/pull/587#discussion_r335551241
 
 

 ##########
 File path: tests/system_tests_sasl_plain.py
 ##########
 @@ -22,15 +22,31 @@
 from __future__ import absolute_import
 from __future__ import print_function
 
-import os
-from subprocess import PIPE, Popen
-from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT, SkipIfNeeded
+import os, json
+from subprocess import PIPE, STDOUT, Popen
+from system_test import TestCase, Qdrouterd, main_module, DIR, TIMEOUT, SkipIfNeeded, Process
 from system_test import unittest
 from qpid_dispatch.management.client import Node
 from proton import SASL
 
 class RouterTestPlainSaslCommon(TestCase):
 
+    def run_qdmanage(self, cmd, input=None, expect=Process.EXIT_OK,
 
 Review comment:
   We've cut and pasted this code too many times.
   See system_test.py - class QdManager().   It wraps qdmanage and exports operations as methods.  See system_tests_edge_router.py for an example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org