Re: svn commit: r18235 - trunk/subversion/tests/cmdline

[Daniel Rall <dl...@collab.net>]

Why not encode this type of information into the exception itself?

Example:
http://svn.collab.net/viewcvs/svn/trunk/subversion/tests/cmdline/log_tests.py?r1=18179&r2=18217

On Wed, 25 Jan 2006, blair@tigris.org wrote:

> Author: blair
> Date: Wed Jan 25 15:33:52 2006
> New Revision: 18235
> 
> Modified:
>    trunk/subversion/tests/cmdline/trans_tests.py
> 
> Log:
> Make it easier to track down a keyword mismatch error by printing the
> index into the keyword list that failed the match.
> 
> * subversion/tests/cmdline/trans_tests.py
>   (check_keywords):
>     Print the keyword number that failed.
> 
> 
> Modified: trunk/subversion/tests/cmdline/trans_tests.py
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/tests/cmdline/trans_tests.py?rev=18235&p1=trunk/subversion/tests/cmdline/trans_tests.py&p2=trunk/subversion/tests/cmdline/trans_tests.py&r1=18234&r2=18235
> ==============================================================================
> --- trunk/subversion/tests/cmdline/trans_tests.py	(original)
> +++ trunk/subversion/tests/cmdline/trans_tests.py	Wed Jan 25 15:33:52 2006
> @@ -85,8 +85,8 @@
>  
>    for i in range(0,len(actual_kw)):
>      if actual_kw[i] != expected_kw[i]:
> -      print '%s, Expected: %s' % (name, expected_kw[i][:-1])
> -      print '%s, Got:      %s' % (name, actual_kw[i][:-1])
> +      print '%s item %s, Expected: %s' % (name, i, expected_kw[i][:-1])
> +      print '%s item %s, Got:      %s' % (name, i, actual_kw[i][:-1])
>        raise svntest.Failure
>   
>  def setup_working_copy(wc_dir, value_len):
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

-- 

Daniel Rall