[GitHub] [lucene] javanna commented on a diff in pull request #787: LUCENE-10002: replace more usages of search(Query, Collector) in tests

[GitBox <gi...@apache.org>]

javanna commented on code in PR #787:
URL: https://github.com/apache/lucene/pull/787#discussion_r842783772


##########
lucene/core/src/test/org/apache/lucene/search/TestMultiCollector.java:
##########
@@ -99,7 +100,7 @@ public void testCollectionTerminatedExceptionHandling() throws IOException {
       }
       final IndexReader reader = w.getReader();
       w.close();
-      final IndexSearcher searcher = newSearcher(reader);
+      final IndexSearcher searcher = newSearcher(reader, true, true, false);

Review Comment:
   In this case, it did not feel necessary to write a collector manager able to handle concurrency. I went for executing the test from a single threaded searcher instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org