You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/22 11:10:49 UTC

[GitHub] [superset] diegomedina248 commented on a diff in pull request #20305: fix(chart): Time Column configuration doesn't accept Custom SQL

diegomedina248 commented on code in PR #20305:
URL: https://github.com/apache/superset/pull/20305#discussion_r951310309


##########
superset/charts/schemas.py:
##########
@@ -1002,12 +1002,12 @@ class Meta:  # pylint: disable=too-few-public-methods
         allow_none=True,
     )
     filters = fields.List(fields.Nested(ChartDataFilterSchema), allow_none=True)
-    granularity = fields.String(
+    granularity = fields.Raw(

Review Comment:
   Doesn't this apply to other engines? I think I tested with postgres at the time 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org