You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Kollishion (via GitHub)" <gi...@apache.org> on 2026/10/10 16:54:54 UTC
[PR] fix: align command data class names with CQRS conventions [fineract-consumer-facing]
Kollishion opened a new pull request, #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Commits must be signed to merge — see CONTRIBUTING.md#signing-your-commits if you haven't set this up. -->
<!--
New feature, or a change to what a consumer can see or do?
Apache Fineract decides those on its developer mailing list, not in a pull request. A PR
that arrives with a thread behind it is reviewed on its merits; one that proposes something
nobody has seen spends its first round of review on the proposal instead of the code.
Subscribe dev-subscribe@fineract.apache.org (blank email)
Post dev@fineract.apache.org
Archive https://lists.apache.org/list.html?dev@fineract.apache.org
Chat https://matrix.to/#/%23apache-fineract-dev:matrix.org
Bug fixes, refactors and test work need none of this.
Found a security problem? Do not open a PR or an issue: see SECURITY.md.
-->
## What and why
Renamed three command-side data classes to follow the CQRS naming conventions documented in `AGENTS.md`. Updated all affected references, including service implementations, adapters, and tests.
Closes #187
## Verification
- `git diff --cached --check` — passed.
- Reviewed the renamed classes and updated references.
- Gradle architecture and full tests could not be completed because `generateFineractClient` failed with a Java heap space error in the local environment.
- No UI changes; Docker-based E2E testing is not applicable.
## Screenshots
Not applicable — backend-only refactoring.
## AI assistance (optional)
- Tool / model: OpenAI ChatGPT
- Harness / workflow: Assistance with code review, Git commands, and PR preparation. Changes were reviewed locally by the contributor.
## Checklist
- [x] I did not hand-edit generated files under `frontend/src/openapi-client/`.
- [x] Backend code follows the feature and CQRS layout in `AGENTS.md`.
- [x] I did not add entries to a lint or architecture baseline to get the build passing.
- [x] User-facing strings use translation keys.
- [ ] I added or updated tests appropriate to this change, or explained why tests were not needed.
- [x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant.
- [ ] Commits are signed — see Signing your commits in CONTRIBUTING.md.
- [x] I followed the AI-assisted contributions guidance.
- [x] If this adds a feature or changes what a consumer can see or do, I raised it on the dev mailing list first, or it is a bug fix, refactor or test change, where that does not apply.
Checklist
[x] I did not hand-edit generated files under frontend/src/openapi-client/.
[x] Backend code follows the feature and CQRS layout in AGENTS.md.
[x] I did not add entries to a lint or architecture baseline to get the build passing.
[x] User-facing strings use translation keys.
[] I added or updated tests appropriate to this change, or explained why tests were not needed.
[x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant.
[] Commits are signed — see Signing your commits in CONTRIBUTING.md.
[x] I followed the AI-assisted contributions guidance.
[x] If this adds a feature or changes what a consumer can see or do, I raised it on the dev mailing list first, or it is a bug fix, refactor or test change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: align command data class names with CQRS conventions [fineract-consumer-facing]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6099931378
<!-- signed-commits -->
## Commits on this pull request are not verified
1 of 1 commit is not showing as **Verified** on GitHub, so this pull request cannot be merged into `main` yet.
### `unknown_key`
The signing key is not registered on your GitHub account.
- `20cbaeb3` fix: align command data class names with CQRS conventions
**How to fix:** Add the public half of your signing key under Settings → SSH and GPG keys, as a **signing** key, then re-sign.
### Re-signing
```bash
# only for the identity reasons above (no_user / unverified_email):
git config user.email "you@example.com"
# re-sign every commit on this branch:
git rebase --exec 'git commit --amend --no-edit --reset-author -S' origin/main
git push --force-with-lease
```
Force-pushing is expected here: re-signing rewrites the commits, so their hashes change.
---
This comment is posted automatically and updates itself when you push; it disappears once every commit verifies. If you believe this is wrong, say so on the pull request; a maintainer can check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: align command data class names with CQRS conventions [fineract-consumer-facing]
Posted by "Kollishion (via GitHub)" <gi...@apache.org>.
Kollishion commented on PR #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6153453622
Pushed the requested changes: rebased on main, removed the freeze wrapper from the command-side naming rule, deleted its store file, and updated modules.adoc (that rule is now marked hard).
Heads up: my laptop only has 8 GB of RAM, and the project’s Gradle setup asks for a 12 GB heap, so the OpenAPI client generation runs out of memory locally and I couldn’t run the full test suite. I did confirm with git grep that no references to the old class names remain. I’m relying on CI for the full check, and I’ll fix anything it flags.
@Aman-Mittal @edk12564 , could you take another look when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: align command data class names with CQRS conventions [fineract-consumer-facing]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on PR #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6117819415
@Kollishion Can you also address @edk12564 review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: align command data class names with CQRS conventions [fineract-consumer-facing]
Posted by "edk12564 (via GitHub)" <gi...@apache.org>.
edk12564 commented on PR #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6114013272
@Kollishion Thanks for the contribution! The renames are clean and the test update is appreciated.
However, could you also remove the freeze wrapper from ArchUnit tests, and remove the archunit store of frozen violations now that the issue is fixed. Please rebase new changes to see these. Also please update modules.adoc as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: align command data class names with CQRS conventions [fineract-consumer-facing]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal merged PR #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: align command data class names with CQRS conventions [fineract-consumer-facing]
Posted by "Kollishion (via GitHub)" <gi...@apache.org>.
Kollishion commented on PR #196:
URL: https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6152720298
Thanks for the feedback! I’m working on these changes. It may take some
time to go through the files, remove the freeze wrapper and frozen
violations store, rebase the changes, and update modules.adoc. I’ll push
the updates once everything is done.
On Mon, Oct 12, 2026 at 3:03 AM Edward Kang ***@***.***>
wrote:
> *edk12564* left a comment (apache/fineract-consumer-facing#196)
> <https://github.com/apache/fineract-consumer-facing/pull/196#issuecomment-6114013272>
>
> @Kollishion <https://github.com/Kollishion> Thanks for the contribution!
> The renames are clean and the test update is appreciated.
>
> However, could you also remove the freeze wrapper from ArchUnit tests, and
> remove the archunit store of frozen violations now that the issue is fixed.
> Please rebase new changes to see these. Also please update modules.adoc as
> well.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract-consumer-facing/pull/196?email_source=notifications&email_token=A6CLPYQJTLPNF7ECEQ64QMD5TP4CFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJRGQYDCMZSG4ZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6114013272>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A6CLPYXWZCNJ5HFJGTPOD335TP4CFAVCNFSNUABGKJSXA33TNF2G64TZHMYTENBUGIZDMNJQG45US43TOVSTWNJXHEZTGNBXGEZTJILWAI>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/A6CLPYSRIGVSBARBW6PRPTD5TP4CFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJRGQYDCMZSG4ZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/A6CLPYX4XEMAAIMFXFH4KUL5TP4CFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJRGQYDCMZSG4ZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org