[GitHub] [avro] martin-g commented on a change in pull request #1484: AVRO-3334 Updated GetNullableType to simplify execution

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #1484:
URL: https://github.com/apache/avro/pull/1484#discussion_r796496760



##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGen.cs
##########
@@ -989,29 +990,34 @@ internal static string getType(Schema schema, bool nullible, ref bool nullibleEn
         /// <returns>
         /// schema that is nullable.
         /// </returns>
+        /// <exception cref="System.ArgumentNullException">schema - UnionSchema can not be null.</exception>
+        [Obsolete("Use GetNullableType. This method will be deprecated in a future release.")]

Review comment:
       Am I wrong or `[Obsolete]` in C# is the same as `@Deprecated` in Java ?
   I.e. by adding `[Obsolete]` the following statement is already deprecated?
   If I am correct then the message should say `This method is deprecated and it will be removed in a future release.`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org