You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/30 05:08:45 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34264: [SPARK-36462][K8S] Add the ability to selectively disable watching or polling
dongjoon-hyun commented on a change in pull request #34264:
URL: https://github.com/apache/spark/pull/34264#discussion_r758934740
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -395,6 +395,23 @@ private[spark] object Config extends Logging {
.checkValue(interval => interval > 0, s"Logging interval must be a positive time value.")
.createWithDefaultString("1s")
+ val KUBERNETES_EXECUTOR_ENABLE_API_POLLING =
+ ConfigBuilder("spark.kubernetes.executor.enableApiPolling")
+ .doc("If Spark should poll Kubernetes for executor pod status. " +
+ "You should leave this enabled unless your encountering performance issues with your etcd.")
+ .version("3.3.0")
+ .booleanConf
+ .createWithDefault(true)
+
+ val KUBERNETES_EXECUTOR_ENABLE_API_WATCHER =
+ ConfigBuilder("spark.kubernetes.executor.enableApiWatcher")
+ .doc("If Spark should create watchers for executor pod status. " +
+ "You should leave this enabled unless your encountering performance issues with your etcd.")
+ .version("3.3.0")
+ .booleanConf
+ .createWithDefault(true)
+
+
Review comment:
nit. extra empty line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org