[GitHub] [cassandra] krummas commented on a change in pull request #368: [CASSANDRA-15332] When building MerkleTrees if a CorruptSSTableException is thrown the DiskFailurePolicy does not get applied

[GitBox <gi...@apache.org>]

krummas commented on a change in pull request #368: [CASSANDRA-15332] When building MerkleTrees if a CorruptSSTableException is thrown the DiskFailurePolicy does not get applied
URL: https://github.com/apache/cassandra/pull/368#discussion_r340105176
 
 

 ##########
 File path: src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
 ##########
 @@ -282,30 +310,79 @@ public static Throwable extractThrowable(Runnable runnable)
                 return e.getCause();
             }
         }
-
         return null;
     }
 
+    /**
+     * If a task wraps a {@link Future} then it should implement this interface to expose the underlining future for
+     * {@link #extractThrowable(Runnable)} to handle.
+     *
+     * @param <T>
+     */
+    private interface HasDelegateFuture<T>
 
 Review comment:
   no need for `<T>` here, can return `Future<?>` instead

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org