You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (Created) (JIRA)" <ji...@apache.org> on 2012/01/06 02:09:40 UTC
[jira] [Created] (HBASE-5132) Amend HBASE-3836: Track master event
handlers
Amend HBASE-3836: Track master event handlers
---------------------------------------------
Key: HBASE-5132
URL: https://issues.apache.org/jira/browse/HBASE-5132
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.4, 0.92.0
Reporter: Andrew Purtell
Consider exposing master event handler state as monitored tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5132) Amend HBASE-3836: Track master
event handlers
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185976#comment-13185976 ]
jiraposter@reviews.apache.org commented on HBASE-5132:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3401/#review4377
-----------------------------------------------------------
lgtm
Whats it like when its in place Andrew? It looks ok?
- Michael
On 2012-01-06 03:06:26, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3401/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-06 03:06:26)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Consider exposing master event handler state as monitored tasks.
bq.
bq.
bq. This addresses bug HBASE-5132.
bq. https://issues.apache.org/jira/browse/HBASE-5132
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
bq. src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java 5af0690
bq. src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 78bb5bf
bq. src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java f171a5a
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
bq. src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java 2d544dd
bq. src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 76c98b3
bq.
bq. Diff: https://reviews.apache.org/r/3401/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. None yet.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> Amend HBASE-3836: Track master event handlers
> ---------------------------------------------
>
> Key: HBASE-5132
> URL: https://issues.apache.org/jira/browse/HBASE-5132
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Andrew Purtell
>
> Consider exposing master event handler state as monitored tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5132) Amend HBASE-3836: Track master
event handlers
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186033#comment-13186033 ]
jiraposter@reviews.apache.org commented on HBASE-5132:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3401/#review4380
-----------------------------------------------------------
I feel this patch should go in after we reach agreement on HBASE-5174.
src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
<https://reviews.apache.org/r/3401/#comment9853>
We'd better wrap this in a finally block.
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
<https://reviews.apache.org/r/3401/#comment9854>
White space.
- Ted
On 2012-01-06 03:06:26, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3401/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-06 03:06:26)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Consider exposing master event handler state as monitored tasks.
bq.
bq.
bq. This addresses bug HBASE-5132.
bq. https://issues.apache.org/jira/browse/HBASE-5132
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
bq. src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java 5af0690
bq. src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 78bb5bf
bq. src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java f171a5a
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
bq. src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java 2d544dd
bq. src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 76c98b3
bq.
bq. Diff: https://reviews.apache.org/r/3401/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. None yet.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> Amend HBASE-3836: Track master event handlers
> ---------------------------------------------
>
> Key: HBASE-5132
> URL: https://issues.apache.org/jira/browse/HBASE-5132
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Andrew Purtell
>
> Consider exposing master event handler state as monitored tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5132) Amend HBASE-3836: Track master
event handlers
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186081#comment-13186081 ]
jiraposter@reviews.apache.org commented on HBASE-5132:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3401/#review4382
-----------------------------------------------------------
Looks good.
Does it overwhelm the status display in the UI?
- Lars
On 2012-01-06 03:06:26, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3401/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-06 03:06:26)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Consider exposing master event handler state as monitored tasks.
bq.
bq.
bq. This addresses bug HBASE-5132.
bq. https://issues.apache.org/jira/browse/HBASE-5132
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
bq. src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java 5af0690
bq. src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 78bb5bf
bq. src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java f171a5a
bq. src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
bq. src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java 2d544dd
bq. src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 76c98b3
bq.
bq. Diff: https://reviews.apache.org/r/3401/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. None yet.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> Amend HBASE-3836: Track master event handlers
> ---------------------------------------------
>
> Key: HBASE-5132
> URL: https://issues.apache.org/jira/browse/HBASE-5132
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Andrew Purtell
>
> Consider exposing master event handler state as monitored tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5132) Amend HBASE-3836: Track master
event handlers
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181066#comment-13181066 ]
jiraposter@reviews.apache.org commented on HBASE-5132:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3401/
-----------------------------------------------------------
(Updated 2012-01-06 03:06:26.539416)
Review request for hbase and Michael Stack.
Changes
-------
Fix task descriptions. Remove redundant notifications on table create and delete.
Summary
-------
Consider exposing master event handler state as monitored tasks.
This addresses bug HBASE-5132.
https://issues.apache.org/jira/browse/HBASE-5132
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java 5af0690
src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 78bb5bf
src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java f171a5a
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java 2d544dd
src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 76c98b3
Diff: https://reviews.apache.org/r/3401/diff
Testing
-------
None yet.
Thanks,
Andrew
> Amend HBASE-3836: Track master event handlers
> ---------------------------------------------
>
> Key: HBASE-5132
> URL: https://issues.apache.org/jira/browse/HBASE-5132
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Andrew Purtell
>
> Consider exposing master event handler state as monitored tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5132) Amend HBASE-3836: Track master
event handlers
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181021#comment-13181021 ]
jiraposter@reviews.apache.org commented on HBASE-5132:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3401/
-----------------------------------------------------------
Review request for hbase and Michael Stack.
Summary
-------
Consider exposing master event handler state as monitored tasks.
This addresses bug HBASE-5132.
https://issues.apache.org/jira/browse/HBASE-5132
Diffs
-----
src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 2dfc3e7
src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java 4600991
src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java 5af0690
src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 78bb5bf
src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java f171a5a
src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 76c98b3
src/main/java/org/apache/hadoop/hbase/master/handler/SplitRegionHandler.java 2d544dd
src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 2dd497b
Diff: https://reviews.apache.org/r/3401/diff
Testing
-------
None yet.
Thanks,
Andrew
> Amend HBASE-3836: Track master event handlers
> ---------------------------------------------
>
> Key: HBASE-5132
> URL: https://issues.apache.org/jira/browse/HBASE-5132
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4, 0.92.0
> Reporter: Andrew Purtell
>
> Consider exposing master event handler state as monitored tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira