You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/25 11:01:20 UTC

[GitHub] [shardingsphere] lanchengx commented on a change in pull request #16365: Add SQL parser test case for `ALTER INSTANCE instanceId SET XA_RECOVERY_NODES = value1,value2.`

lanchengx commented on a change in pull request #16365:
URL: https://github.com/apache/shardingsphere/pull/16365#discussion_r835165939



##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/common.xml
##########
@@ -52,6 +52,6 @@
     <distsql-case id="prepare-distsql" value="PREPARE DISTSQL" />
     <distsql-case id="apply-distsql" value="APPLY DISTSQL" />
     <distsql-case id="discard-distsql" value="DISCARD DISTSQL" />
-    <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308" />
+    <distsql-case id="alter-instance-xa-recovery-nodes" value="ALTER INSTANCE 1.2.3.4@3307 SET XA_RECOVERY_NODES=1.2.3.4@3308,1.2.3.4@3307" />

Review comment:
       This case might be better as a new test case, and it may need a new name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org