[GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...

[ggevay <gi...@git.apache.org>]

Github user ggevay commented on the issue:

    https://github.com/apache/flink/pull/1517
  
    > Reading back through the discussion I see that there are many ideas for future performance enhancements. If not already suggested I'd like to consider skipping staging for fixed length records.
    
    Thanks, I've added this to my notes.
    
    > I'm missing why we can't update in place with smaller records. The deserializer is responsible for detecting the end of the record and we wouldn't need to change the pointer value when replacing with a smaller record.
    
    A problem would arise in `EntryIterator`: after reading a record, we wouldn't know where the next record starts. (As it is now, it always starts right after the previous.)
    
    Thanks @greghogan for pushing this forward. I think I have addressed all your comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---