You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 07:51:23 UTC

[GitHub] [arrow] jeroen opened a new pull request #10372: R: also build ucrt64 binaries

jeroen opened a new pull request #10372:
URL: https://github.com/apache/arrow/pull/10372


   Testing if this works...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jeroen commented on pull request #10372: ARROW-11926: [R] Add ucrt64 binaries and fix CI

Posted by GitBox <gi...@apache.org>.
jeroen commented on pull request #10372:
URL: https://github.com/apache/arrow/pull/10372#issuecomment-848122974


   You can use the ucrt build of R: https://github.com/r-windows/docs/blob/master/ucrt.md#readme 
   But this is pretty experimental perhaps you don't need to automate that part yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #10372: ARROW-11926: [R] Add ucrt64 binaries and fix CI

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10372:
URL: https://github.com/apache/arrow/pull/10372#issuecomment-848068290


   Thanks @jeroen. Do you have a pointer to how to test the UCRT build?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10372: ARROW-11926: also build ucrt64 binaries

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10372:
URL: https://github.com/apache/arrow/pull/10372#issuecomment-845796987


   https://issues.apache.org/jira/browse/ARROW-11926


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson closed pull request #10372: ARROW-11926: [R] Add ucrt64 binaries and fix CI

Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #10372:
URL: https://github.com/apache/arrow/pull/10372


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10372: R: also build ucrt64 binaries

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10372:
URL: https://github.com/apache/arrow/pull/10372#issuecomment-845741586


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #10372: ARROW-11926: [R] Add ucrt64 binaries and fix CI

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10372:
URL: https://github.com/apache/arrow/pull/10372#discussion_r639231494



##########
File path: ci/scripts/r_windows_build.sh
##########
@@ -27,10 +27,10 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
   # Use rtools-backports if building with rtools35
   curl https://raw.githubusercontent.com/r-windows/rtools-backports/master/pacman.conf > /etc/pacman.conf
   # Update keys: https://www.msys2.org/news/#2020-06-29-new-packagers
-  msys2_repo_base_url=https://repo.msys2.org/msys
-  curl -OSsL "${msys2_repo_base_url}/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz"
-  pacman -U --noconfirm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz && rm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
-  pacman --noconfirm -Scc
+  #msys2_repo_base_url=https://repo.msys2.org/msys
+  #curl -OSsL "${msys2_repo_base_url}/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz"
+  #pacman -U --noconfirm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz && rm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
+  #pacman --noconfirm -Scc

Review comment:
       ```suggestion
   ```

##########
File path: ci/scripts/r_windows_build.sh
##########
@@ -27,10 +27,10 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
   # Use rtools-backports if building with rtools35
   curl https://raw.githubusercontent.com/r-windows/rtools-backports/master/pacman.conf > /etc/pacman.conf
   # Update keys: https://www.msys2.org/news/#2020-06-29-new-packagers

Review comment:
       ```suggestion
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org