You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/19 11:08:25 UTC
[GitHub] [logging-log4j2] KristjanESPERANTO opened a new pull request #642: Add Link to Release History
KristjanESPERANTO opened a new pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642
It's a minor detail, but I didn't find any reference to the release history in the repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] KristjanESPERANTO commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001077412
Then you will never find a reference to the current release notes in the master branch. If that's the way you want it, I don't understand it, but that's okay too :slightly_smiling_face:
Thank you very much for your patience and your work on log4j! 🎆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001158550
I see your point @KristjanESPERANTO, maybe we should set the default branch to `release-2.x`. I guess this addresses your concern, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000890111
Hrm... I will do it myself. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] larrywest42 edited a comment on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
larrywest42 edited a comment on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000418438
That's a helpful change, especially as the most recent version mentioned in "RELEASE-NOTES.md" is `2.11.0`, from 2018.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] KristjanESPERANTO commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000997057
When will the changes be transferred from the `release-2.x` branch to the master branch?
The `RELEASE-NOTES.md` in the master branch is still outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000889999
@KristjanESPERANTO, thanks for the contribution! This update needs to go into `announcement.vm` in `release-2.x` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] KristjanESPERANTO edited a comment on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
KristjanESPERANTO edited a comment on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001190408
Yes, that would address my point. The master branch is now the entry point for people who want to start dealing with the code. Since I can also see current changes in this branch, it seems a bit inconsistent to find old release notes in there.
I have no idea about best practice, I'm just trying to give some feedback here :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] larrywest42 commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
larrywest42 commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1000418438
That's a helpful change, especially as the most recent version mentioned in "RELEASE-NOTE.md" is `2.11.0`, from 2018.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy closed pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
vy closed pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
vy commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001070873
> When will the changes be transferred from the release-2.x branch to the master branch?
[Never, since every release will have its own content.](https://lists.apache.org/thread/zrn7f1hz38x9q9vo8wmfbdb46w3wqtnm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] KristjanESPERANTO commented on pull request #642: Add Link to Release History
Posted by GitBox <gi...@apache.org>.
KristjanESPERANTO commented on pull request #642:
URL: https://github.com/apache/logging-log4j2/pull/642#issuecomment-1001190408
Yes, that would address my point. The master branch is now the entry point for people who want to start dealing with the code. Since I can also see current changes this branch, it seems a bit inconsistent to find old release notes in there.
I have no idea about best practice, I'm just trying to give some feedback here :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org